-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build system to use core-js 3 #13981
Conversation
9d04883
to
11e1e26
Compare
11e1e26
to
8ec97f4
Compare
8ec97f4
to
50a78e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
97c0535
to
529f824
Compare
waiting for PR angular/angular-cli#13981 to be merged and released
import 'core-js/es/promise'; | ||
|
||
// ES2015 object capabilities | ||
import 'core-js/es/object/create'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it necessary to import each function individually?
Why not import everything at once by import 'core-js/es/object';
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Angular only requires the ES2015 polyfills. In core-js
3.0, core-js/es/object
includes all current ES polyfills (up to ES2019). This was an attempt to reduce the bundle size increase. Using the single imports resulted in an increase of ~15kb to the polyfills file. Further work is currently being done to attempt to close the gap even further.
…rojects Required polyfills are now managed directly by the build system. If additional polyfills are required, packages can be manually added as needed.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Also, required ES polyfills are now managed directly by the build system. If additional polyfills are required, packages can be manually added as needed. This reduces the number of direct dependencies for a new project.