fix(@schematics/update): fix update on local packages #13066
Conversation
pacote requires the `@version` to determine if the package is local, git, http or in the npm repo. Fixes #13059
alan-agius4
added
the
target: patch
| // Grab all package.json from the npm repository. This requires a lot of HTTP calls so we | ||
| // try to parallelize as many as possible. | ||
| mergeMap(depName => getNpmPackageJson(depName, options.registry, logger, usingYarn)), | ||
| mergeMap(([depName, version]) => | ||
| getNpmPackageJson(`${depName}@${version}`, options.registry, logger, usingYarn)), |
There was a problem hiding this comment.
Was not certain if to add an addition param or not.
There was a problem hiding this comment.
That function is intended to pull all version information from the registry not just a particular version. A more complex change is needed to the full update algorithm to account for package data that does not contain full version history.
| // Grab all package.json from the npm repository. This requires a lot of HTTP calls so we | ||
| // try to parallelize as many as possible. | ||
| mergeMap(depName => getNpmPackageJson(depName, options.registry, logger, usingYarn)), | ||
| mergeMap(([depName, version]) => | ||
| getNpmPackageJson(`${depName}@${version}`, options.registry, logger, usingYarn)), |
There was a problem hiding this comment.
That function is intended to pull all version information from the registry not just a particular version. A more complex change is needed to the full update algorithm to account for package data that does not contain full version history.
|
Closing for now |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
pacote requires the
@versionto determine if the package is local, git, http or in the npm repo.Fixes #13059