Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing does not work on GitHub Pages #995

Closed
kutyel opened this issue Jun 3, 2016 · 5 comments · Fixed by #1020
Closed

routing does not work on GitHub Pages #995

kutyel opened this issue Jun 3, 2016 · 5 comments · Fixed by #1020
Assignees
Labels
effort1: easy (hours) P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix

Comments

@kutyel
Copy link

kutyel commented Jun 3, 2016

  1. OS? Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
    any
  2. Versions. Please run ng --version. If there's nothing outputted, please run in a Terminal:
    any
  3. Repro steps. Was this an app that wasn't created using the CLI? What change did you
    do on your code? etc.
    The app was fully created with the angular-cli
  4. The log given by the failure. Normally this include a stack trace and some
    more information.
    Error 404
  5. Mention any other details that might be useful.
    I have an Angular 2 App deployed via GitHub Pages (using the CLI) here, whether you refresh the page or navigate using deep linking it does not work and an Error 404 from GitHub is given. I have used the CLI to generate the routes and used the new router (not the router-deprecated).
@filipesilva
Copy link
Contributor

I'll pick this up. There is a solution in #41 (comment) but I haven't implemented it yet.

@filipesilva filipesilva added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful effort1: easy (hours) labels Jun 4, 2016
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jun 6, 2016
@kutyel
Copy link
Author

kutyel commented Jun 6, 2016

@filipesilva that solves the weird Github 404 Issue, but it does not fix deep linking, like when navigating to https://kutyel.github.io/famous-painters/painter/3, for example. I bet there is something missing...

hansl pushed a commit that referenced this issue Jun 7, 2016
@filipesilva
Copy link
Contributor

@kutyel perhaps the missing bit now is related to #989 (comment)?

@kutyel
Copy link
Author

kutyel commented Jun 7, 2016

@filipesilva you are right, I will keep track of the changes made to the new router, thanks! 👍

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort1: easy (hours) P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants