-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files declared in .angular-cli "assets" are not copied #9230
Comments
I have the same problem, even with 1.6.5. |
I am experiencing this behavior as well, seems to work okay on a Windows 10 box, but seeing the issue on a Windows Server 2008 R2 box, using 1.6.5, |
I can't reproduce myself on my Windows 10 machine. @blovell33's report indicates it might be OS related. @dgsqrs are you on windows as well? If so, what version? Is anyone using symlinks/junction or anything of the sort in their projects? There was a commit related to asset copy (c7735ab) merged between 1.6.3 and 1.6.4. This commit runs some extra processing on the path. Maybe it's related to the path used. @rbluethl @dgsqrs @blovell33 can you show me the full path for the assets folder in the system where it does not work? /cc @clydin |
Thanks for looking into this. |
I'm experiencing the same issue with version If I try downgrading to version
Even after installing the package with |
@enriquegarciagutierrez can you show me the full path for the assets folder in the system where it does not work? |
@filipesilva I'm using Osx but I got the same problem using Ubuntu. I don't know what information I can give you, actually. I did a ng serve and it worked. ng serve --prod does not work and I just saw that the scss are missing, but only those from my assets folder. I have no error, nowhere. |
Hi @filipesilva The folder is currently located in I tried creating the project again in
Edit: Never mind, it wasn't copying because there was no content inside assets folder. As soon as I copied some files inside it worked like a charm! So maybe it has to be with the folder path containing weird characters such as |
@filipesilva This issue does not existing using 1.7.0-beta.1 (but I have others) |
@rbluethl @blovell33 @enriquegarciagutierrez can you try using |
Hi @filipesilva Same result using
Edit: tried renaming Seems to be something related to certain symbols on folder names. |
Late seeing this... Path where it works. Path where it does not work. I will try later today with with Maybe an issue with special characters in path, I can copy folder to different location and test. |
We've narrowed it down to special characters, yeah. Sorry about that. @clydin is working on a PR in webpack-contrib/copy-webpack-plugin#208 to fix all cases. BTW for now a workaround is to use a path without special characters. |
I'm also facing same issue while upgrading angular cli from 1.6.6 to 1.6.7. Update: |
I went from 1.6.3 to 1.6.7 and I am having a similar issue. My assets and favicon are not included. The build is done on jenkins: |
Can report this is an issue for "@angular/cli": "1.4.3" as well, have been using the following all along.
build string |
Hi. @angular/cli - 1.7.0 ejected webpack config:
copy-webpack-plugin debug output:
|
I am also having the same issue still after upgrading to 1.7.0. Running from a Jenkins build process on windows Server 2012 R2. The build folder was under /Program Files (x86). However I moved the build folder to a different directory with no parenthesis and that did fix the problem as @filipesilva indicated. |
issue with angular cli new CopyWebpackPlugin([ should be |
I am able to replicate this issue with Angular-CLI 1.7.2 on Jenkins running on a windows box. It does seems that special characters is the issue. |
got the same problem when i upgraded CLI from 1.6.7 to 1.7.3. downgrading to 1.6.7 fixed it. |
Can confirm that folders with '(' and ')' (like any Dropbox folder) cause the assets not to be included in serve nor build. |
I have the same problem with Jenkins with angular cli 1.6-1.7. I have a project with cli 1.5.5 without problems. Jenkins has a workspace folder C:\Program Files (x86)\Jenkins\workspace. I changed it to C:\jenkinsworkspace and the problem is gone. So problem is in 'Program Files (x86)' |
Yea, problem is any directory with parenthesis
Juhana Lehtiniemi
www.juhanalehtiniemi.com
+358 50 3022308
… Oleg Sulima ***@***.***> kirjoitti 7.4.2018 kello 17.30:
I have the same problem with Jenkins with angular cli 1.6-1.7. I have a project with cli 1.5.5 without problems. Jenkins has a workspace folder C:\Program Files (x86)\Jenkins\workspace. I changed it to C:\jenkinsworkspace and the problem is gone. So problem is in 'Program Files (x86)'
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Is this issue fixed in angular-cli 1.7.4 ? I have the same issue , changing jenkins path will be difficult for me as there are many dependent jobs. |
@sri7vasu we had the issue at work with Jenkins where we couldn't just willy nilly change the path - my "fix" was to create an extra task to run after building the project, that copies our assets manually. Very bandaid, so hopefully this will get resolved soon (maybe with the release of 6.0?) |
still an issue in 6.0.2 |
still an issue @6.0.3
As already mentioned: The angular-cli can't handle parenthesis ( '(' and ')' ) in directories correctly. |
On my localhost I'm running: On Jenkins (CI) server: On my localhost it includes the assets, but not on Jenkins. The only difference is the NodeJS Version. Hope that helps to identify issue a little closer |
It looks like the tracking issue for this problem in the webpack plugin we use is webpack-contrib/copy-webpack-plugin#231. There seems to be a fix on the way as well: webpack-contrib/copy-webpack-plugin#264 |
I was investigating this issue on our Jenkins server and then find out that the issue is the workspace folder contains a space character. If moved to the location where the full path didn't contain any spaces, it compiled properly. Mea culpa, should've checked earlier. |
A half year past now + a major release of angluar and the issue still occurs? Are you kidding me? It can't be that complicated after all this worked a couple releases before. |
This may be related. Currently, I am using to 6.0.7 I have multiple projects in a workspace. So my assets read like this:
If I add
If I add
|
@filipesilva |
Since the fix is now in copy-webpack-plugin and released, some users should get it straight away. You can force your npm lockfile to use it by doing this:
This should force your lockfile to recognize the new version and use it inside I also put up #11437 which bumps our minimum version. It should go in sometime in the 6.1.x life time. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Versions
Repro steps
My assets are defined as follows in
.angular-cli.json
(pretty much the default configuration):However, the files are not copied. Neither the assets folder, nor the favicon.
This only arises with @angular/[email protected]. With 1.6.3, everything works fine.
Mention any other details that might be useful (optional)
Can't really tell you anything else, as no errors or whatsoever are thrown during the build.
The declared assets are just missing in the output directory upon build completion.
The text was updated successfully, but these errors were encountered: