[bug] Uncaught ReferenceError: global is not defined #8160

amitport · 2017-10-24T07:42:49Z

Bug Report or Feature Request (mark with an `x`)

- [X] bug report -> please search issues before submitting
- [ ] feature request

Versions.

Angular CLI: 1.5.0-rc.3
Node: 8.7.0
OS: win32 x64
Angular: 4.4.6
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router, tsc-wrapped, upgrade

@angular/cdk: 2.0.0-beta.12
@angular/cli: 1.5.0-rc.3
@angular/flex-layout: 2.0.0-beta.9
@angular/material: 2.0.0-beta.12
@angular-devkit/build-optimizer: 0.0.30
@angular-devkit/core: 0.0.20
@angular-devkit/schematics: 0.0.34
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.8.0-rc.3
@schematics/angular: 0.0.48
typescript: 2.3.4
webpack: 3.8.1

Repro steps.

create angular/cli project
add dependency and import [email protected]
ng serve --aot
open browser

The log given by the failure.

index.js:10 Uncaught ReferenceError: global is not defined
    at eval (index.js:10)
    at Object.../../../../has-binary2/index.js (vendor.bundle.js:2914)
    at __webpack_require__ (inline.bundle.js:55)
    at eval (index.js:8)
    at Object.../../../../socket.io-parser/index.js (vendor.bundle.js:9569)
    at __webpack_require__ (inline.bundle.js:55)
    at eval (index.js:7)
    at Object.../../../../socket.io-client/lib/index.js (vendor.bundle.js:9527)
    at __webpack_require__ (inline.bundle.js:55)
    at eval (io-service.ts:1)

The text was updated successfully, but these errors were encountered:

dottodot · 2017-10-24T08:28:28Z

I seeing the same issue as well with ng-socket-io but also with import 'intl'; in polyfills.ts

amitport · 2017-10-24T08:36:51Z

I tried adding (window as any).global = window; to pollyfils.ts, but it didn't work.
reverting to 1.5.0-rc.1 worked

dottodot · 2017-10-24T08:49:51Z

Strange I've reverted to 1.5.0-rc.2 and still get it, no idea what's going on.

amitport · 2017-10-24T08:52:34Z

@dottodot
oh sorry, I actually reverted to 1.5.0-rc.1
in any case, make sure it's a clean revert. try deleting node_modules and packge/yarn-lock before npm i

dottodot · 2017-10-24T08:59:39Z

Thanks that worked. I've gone back to 1.5.0-rc.2 and that's ok for me so seems like the issue is in 1.5.0-rc.3

Martin-Luft · 2017-10-24T12:53:40Z

Same problem here since 1.5.0-rc.3, with 1.5.0-rc.2 no problems...

robisim74 · 2017-10-25T09:31:19Z

Same error using rc.3 Uncaught ReferenceError: global is not defined also importing another library (jsrsasing). It worked fine until rc.2.

RicardoVaranda · 2017-10-25T10:27:13Z

Hi guys, could you please provide a simple repo of this issue, that way it's easier and faster for the team to be able to debug the issue.

dottodot · 2017-10-25T10:36:54Z

@RicardoVaranda https://github.com/dottodot/ang5-test

All i've done is create a new project with 1.5.0-rc.3 and included import 'intl'; in polyfills.ts and you get the error

filipesilva · 2017-10-25T10:54:56Z

This is definitely related to #8132 as we've removed the node global object from the compilation environment. I'm investigating what can be done about it.

filipesilva · 2017-10-25T19:31:44Z

Just wanted to let you know we're looking into this. For the intl case using import 'intl/dist/intl'; instead fixes it, but this might not be possible for all libs. socket.io-client also seems to have a dist in socket.io-client/dist/socket.io.js. I don't think the same can be used with ng-socket-io however, since it's importing the node package inside of it...

Fixes angular#8160

MrBlaise · 2017-10-26T09:35:26Z

Hey, I just wanted to chime in. I have the same issue upgrading to 1.5.0-rc.3 causes this issue, 1.5.0-rc.2 works fine. Didn't change anything just upgraded thew version. I use the following polyfills:

import 'core-js/es6/symbol';
import 'core-js/es6/object';
import 'core-js/es6/function';
import 'core-js/es6/parse-int';
import 'core-js/es6/parse-float';
import 'core-js/es6/number';
import 'core-js/es6/math';
import 'core-js/es6/string';
import 'core-js/es6/date';
import 'core-js/es6/array';
import 'core-js/es6/regexp';
import 'core-js/es6/map';
import 'core-js/es6/set';

/** IE10 and IE11 requires the following for NgClass support on SVG elements */
import 'classlist.js';  // Run `npm install --save classlist.js`.

/** IE10 and IE11 requires the following to support `@angular/animation`. */
import 'web-animations-js';  // Run `npm install --save web-animations-js`.


/** Evergreen browsers require these. **/
import 'core-js/es6/reflect';
import 'core-js/es7/reflect';

/***************************************************************************************************
 * Zone JS is required by Angular itself.
 */
import 'zone.js/dist/zone';  // Included with Angular CLI.

bogacg · 2017-10-28T09:52:01Z

With Rc.6 still having same problem.

dottodot · 2017-10-28T09:56:20Z

There's a pull request which I assume will fix it guess we just need to wait for it to be added

#8189

amitport · 2017-10-31T07:17:43Z

This is fixed for me with release 1.5.0-rc.8 (#8250). Thanks!

StojanovicM · 2018-01-10T11:40:09Z

Hi,
I am using Dragula version 1.5.0 with Angular 5, and still having problem
"ReferenceError: global is not defined"

I have just installed it, imported and added to NgModule -> Imports, and my app crashes with this error.

Is there any step I am missing??

filipesilva · 2018-05-02T23:40:00Z

On version 6 of Angular CLI we are removing the shim for global and other node built-ins. You can read more about why this change was made in #9827 (comment).

If you are using a library that assumes these globals are present, you can try manually shimming it inside your polyfills.ts file:

// Add global to window, assigning the value of window itself.
(window as any).global = window;

I ran a quick test with socket.io-client and this seemed to allow it to run.

gioragutt · 2018-05-04T15:09:10Z

@filipesilva Thank you so much!

krishnareddy226 · 2018-05-07T08:45:02Z

declare var $: any;
I am getting the error
$ not defined

yulm6 · 2018-07-09T07:37:12Z

When I adding sockjs-client, I got the same issue.
npm install sockjs-client --save

I did as @tobias74 ,maybe it worked,but the brower refreshes frequenly.

chetanbirajdar · 2018-07-31T08:31:30Z

@tobias74 Thanks that worked

cf angular/angular-cli#8160 (comment)

Evllis · 2018-08-01T08:01:14Z

@filipesilva
Thank you!!!!!!!!! ^_^

see angular/angular-cli#8160 (comment)

SamiHK · 2018-08-25T15:56:53Z

I removed all these things.
import 'intl'; (window as any).global = window; // Run npm install --save intl. import 'intl/locale-data/jsonp/en';

AND NOW :D
This polyfill.ts is working for me.

`import 'core-js/es6/symbol';
import 'core-js/es6/object';
import 'core-js/es6/function';
import 'core-js/es6/parse-int';
import 'core-js/es6/parse-float';
import 'core-js/es6/number';
import 'core-js/es6/math';
import 'core-js/es6/string';
import 'core-js/es6/date';
import 'core-js/es6/array';
import 'core-js/es6/regexp';
import 'core-js/es6/map';
import 'core-js/es6/weak-map';
import 'core-js/es6/set';

import 'core-js/es7/array';

/** IE10 and IE11 requires the following for NgClass support on SVG elements */
import 'classlist.js'; // Run npm install --save classlist.js.

/** IE10 and IE11 requires the following for the Reflect API. */
import 'core-js/es6/reflect';

/** Evergreen browsers require these. **/
// Used for reflect-metadata in JIT. If you use AOT (and only Angular decorators), you can remove.
import 'core-js/es7/reflect';

/**

Required to support Web Animations @angular/common/animations.
Needed for: All but Chrome, Firefox and Opera. http://caniuse.com/#feat=web-animation
**/
import 'web-animations-js'; // Run npm install --save web-animations-js.

/***************************************************************************************************

Zone JS is required by Angular itself.
*/
import 'zone.js/dist/zone'; // Included with Angular CLI.

/***************************************************************************************************

APPLICATION IMPORTS
*/

/**

Fix for ngx-chart to work on ie11
*/
if ( typeof SVGElement.prototype.contains === 'undefined' )
{
SVGElement.prototype.contains = HTMLDivElement.prototype.contains;
}`

avinexus7 · 2018-09-17T13:57:17Z

On version 6 of Angular CLI we are removing the shim for global and other node built-ins. You can read more about why this change was made in #9827 (comment).

If you are using a library that assumes these globals are present, you can try manually shimming it inside your polyfills.ts file:
// Add global to window, assigning the value of window itself.
(window as any).global = window;
I ran a quick test with socket.io-client and this seemed to allow it to run.

Is this the right way of implementing socket.io in Angular 2? I mean does the above line give any side affects that may be obtrusive in the future?

BMLande · 2018-10-08T13:32:36Z

solution of @filipesilva is worked .
i have issue when i am migrating ng5 to ng6 .
thanks @filipesilva

See: angular/angular-cli#8160

with this solution angular/angular-cli#8160 (comment)

* update to Abgular 7.2.x * update travis * bump more packages * at least it builds * update travis * bump package * bump mapbox packages * bump codelyzer * bump core js * fix polyfill error with this solution angular/angular-cli#8160 (comment)

fkolar · 2019-07-12T19:38:49Z

@filipesilva I see this is pretty old issue but even today, newly generated project and I am testing apolo graphql does not add the global.

so I have to add to my polyfills.ts the (window as any).global = window;

Is this normal ?

clydin · 2019-07-12T19:52:19Z

Yes. global does not exist in a browser. A library that supports web browsers should not be using Node.js specific functionality.

willkara · 2019-07-31T01:51:22Z

Will this ever be fixed in the main module? Still apparently happens in new projects.

I've tried adding a basic AwsAmplify project and this happens.

amitport · 2019-07-31T06:01:46Z

@willkara, read the comment right before yours.

Follow the stack trace to see which package uses global. submit an actionable, reproducible issue on that package repo

(also, "happens in new projects." is very different from happened when you "tried adding a basic AwsAmplify")

willkara · 2019-07-31T18:28:15Z

@amitport fair comment. I'll follow the trace again and see where it happens.

danieldanielecki · 2019-08-15T09:13:25Z

In case, if your target is node in webpack (target: 'node'), because you want to fix "Can't resolve 'fs'. Then you're getting the following error Fix: "Uncaught ReferenceError: global is not defined" do it as follows node: { global: true, fs: 'empty' }. Bonus: if you got error "Uncaught ReferenceError: exports is not defined". simply add libraryTarget: 'umd'. The complete webpack config code is below.

const webpackConfig = {
  node: { global: true, fs: 'empty' }, // Fix: "Uncaught ReferenceError: global is not defined", and "Can't resolve 'fs'".
  output: {
    libraryTarget: 'umd' // Fix: "Uncaught ReferenceError: exports is not defined".
  }
};

module.exports = webpackConfig; // Export all custom Webpack configs.

amitport · 2019-08-15T09:27:15Z

@filipesilva can you lock this issue? seem to keep "sprouting" in all directions even though it's closed.

ar1stio · 2019-09-04T06:43:20Z

just add (window as any).global = window; in polyfills.ts in ionic

angular-automatic-lock-bot · 2019-10-05T08:02:51Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

amitport mentioned this issue Oct 24, 2017

[bug] global is not defined socketio/socket.io-client#1166

Closed

filipesilva self-assigned this Oct 25, 2017

filipesilva added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful needs: investigation Requires some digging to determine if action is needed type: bug/fix labels Oct 25, 2017

Brocco added a commit to Brocco/angular-cli that referenced this issue Oct 25, 2017

fix(@angular/cli): Add ability to include node global

9787677

Fixes angular#8160

Brocco mentioned this issue Oct 25, 2017

fix(@angular/cli): Add ability to include node global #8189

Closed

amitport closed this as completed Oct 31, 2017

Brocco mentioned this issue Oct 31, 2017

fix(@angular/cli): Reenable node global #8250

Merged

filipesilva mentioned this issue Oct 31, 2017

mapboxgl is incompatible with the CLI in a production build #5804

Closed

filipesilva mentioned this issue Mar 1, 2018

Can't resolve 'net'/'global' or other node globals #9827

Closed

wnabil mentioned this issue Jun 9, 2018

Nested lazyload modules ngx-rocket/generator-ngx-rocket#331

Closed

3 tasks

nikku mentioned this issue Jul 19, 2018

When used in a Typescript app, error in a bundled lodash files bpmn-io/bpmn-js-properties-panel#271

Closed

hursey013 mentioned this issue Jul 26, 2018

Fix undefined global console error USDAForestService/fs-open-forest-platform#285

Merged

PhilippeCorreges added a commit to jobdoneproject/devoirFaitsFrontNodeJS that referenced this issue Jul 31, 2018

Fixed index.html bug :

2c9c3a8

cf angular/angular-cli#8160 (comment)

justiceo pushed a commit to justiceo/WebChat that referenced this issue Aug 2, 2018

Fix issue with removal shim for global

0f69685

see angular/angular-cli#8160 (comment)

ChrisTomAlx mentioned this issue Aug 16, 2018

Mobile | Android | iOS swipe fails. Uncaught ReferenceError: global is not defined. ksachdeva/angular2-swing#48

Closed

Klerith mentioned this issue Oct 17, 2018

global is not defined FriOne/ng-io#4

Closed

codyburleson pushed a commit to daleewald/topic-ideation-carbonldp that referenced this issue Dec 1, 2018

Fix for console err: Uncaught ReferenceError: global is not defined

346f861

See: angular/angular-cli#8160

codyburleson mentioned this issue Dec 3, 2018

(Carbon LDP + Angular 7.1.1) ReferenceError: global is not defined CarbonLDP/carbonldp-js-sdk#327

Closed

lislis added a commit to Datenschule/datenspaziergang-app that referenced this issue Apr 9, 2019

fix polyfill error

0ec6a70

with this solution angular/angular-cli#8160 (comment)

alan-agius4 mentioned this issue Apr 24, 2019

SignalR Message Pack Client Library not running in browser when using Angular Cli #14253

Closed

fkolar mentioned this issue Jul 12, 2019

Mutation causes :ERROR Error: Network error: global is not defined apollographql/apollo-link-rest#220

Closed

yohny mentioned this issue Sep 21, 2019

Angular 8 - global is not defined chartist-js/chartist#1189

Open

angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bug] Uncaught ReferenceError: global is not defined #8160

[bug] Uncaught ReferenceError: global is not defined #8160

amitport commented Oct 24, 2017 •

edited

Loading

dottodot commented Oct 24, 2017

amitport commented Oct 24, 2017 •

edited

Loading

dottodot commented Oct 24, 2017

amitport commented Oct 24, 2017 •

edited

Loading

dottodot commented Oct 24, 2017

Martin-Luft commented Oct 24, 2017

robisim74 commented Oct 25, 2017

RicardoVaranda commented Oct 25, 2017

dottodot commented Oct 25, 2017

filipesilva commented Oct 25, 2017

filipesilva commented Oct 25, 2017

MrBlaise commented Oct 26, 2017

bogacg commented Oct 28, 2017

dottodot commented Oct 28, 2017

amitport commented Oct 31, 2017 •

edited

Loading

StojanovicM commented Jan 10, 2018 •

edited

Loading

filipesilva commented May 2, 2018 •

edited

Loading

gioragutt commented May 4, 2018

krishnareddy226 commented May 7, 2018

yulm6 commented Jul 9, 2018

chetanbirajdar commented Jul 31, 2018

Evllis commented Aug 1, 2018

SamiHK commented Aug 25, 2018

avinexus7 commented Sep 17, 2018

BMLande commented Oct 8, 2018

fkolar commented Jul 12, 2019

clydin commented Jul 12, 2019

willkara commented Jul 31, 2019

amitport commented Jul 31, 2019 •

edited

Loading

willkara commented Jul 31, 2019

danieldanielecki commented Aug 15, 2019

amitport commented Aug 15, 2019

ar1stio commented Sep 4, 2019

angular-automatic-lock-bot bot commented Oct 5, 2019

[bug] Uncaught ReferenceError: global is not defined #8160

[bug] Uncaught ReferenceError: global is not defined #8160

Comments

amitport commented Oct 24, 2017 • edited Loading

Bug Report or Feature Request (mark with an x)

Versions.

Repro steps.

The log given by the failure.

dottodot commented Oct 24, 2017

amitport commented Oct 24, 2017 • edited Loading

dottodot commented Oct 24, 2017

amitport commented Oct 24, 2017 • edited Loading

dottodot commented Oct 24, 2017

Martin-Luft commented Oct 24, 2017

robisim74 commented Oct 25, 2017

RicardoVaranda commented Oct 25, 2017

dottodot commented Oct 25, 2017

filipesilva commented Oct 25, 2017

filipesilva commented Oct 25, 2017

MrBlaise commented Oct 26, 2017

bogacg commented Oct 28, 2017

dottodot commented Oct 28, 2017

amitport commented Oct 31, 2017 • edited Loading

StojanovicM commented Jan 10, 2018 • edited Loading

filipesilva commented May 2, 2018 • edited Loading

gioragutt commented May 4, 2018

krishnareddy226 commented May 7, 2018

yulm6 commented Jul 9, 2018

chetanbirajdar commented Jul 31, 2018

Evllis commented Aug 1, 2018

SamiHK commented Aug 25, 2018

avinexus7 commented Sep 17, 2018

BMLande commented Oct 8, 2018

fkolar commented Jul 12, 2019

clydin commented Jul 12, 2019

willkara commented Jul 31, 2019

amitport commented Jul 31, 2019 • edited Loading

willkara commented Jul 31, 2019

danieldanielecki commented Aug 15, 2019

amitport commented Aug 15, 2019

ar1stio commented Sep 4, 2019

angular-automatic-lock-bot bot commented Oct 5, 2019

amitport commented Oct 24, 2017 •

edited

Loading

Bug Report or Feature Request (mark with an `x`)

amitport commented Oct 24, 2017 •

edited

Loading

amitport commented Oct 24, 2017 •

edited

Loading

amitport commented Oct 31, 2017 •

edited

Loading

StojanovicM commented Jan 10, 2018 •

edited

Loading

filipesilva commented May 2, 2018 •

edited

Loading

amitport commented Jul 31, 2019 •

edited

Loading