-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please fix refreshing issues #8033
Comments
could you please give steps on how to reproduce this issue ? |
1) ng serve
2) switch to Webstorm (don't touch anything, no edits, no saving)
3) switch to browser
4) ...
5) Page refreshes because HMR thinks files changed when it didn't
Possible solution:
Expose watch ignore parameters in the ng serve command so specific
directories can be ignored.
Prioritize HMR watch better? First check mtime on changed files, then
compare file size, then compare file contents? That's probably a different
repo right?
|
If you feel like this issue already exists please post your reply in the existing issue instead of opening a new one. Having duplicate issues only makes fixing them harder. |
No, it needs fresh eyes since all you do is close things without fixing the
issue.
…On Oct 16, 2017 4:14 AM, "Filipe Silva" ***@***.***> wrote:
If you feel like this issue already exists please post your reply in the
existing issue instead of opening a new one. Having duplicate issues only
makes fixing them harder.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8033 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AX5Xbq6GY37Vg5OodqM7915rW6v7rddJks5sszp8gaJpZM4P3qfe>
.
|
@filipesilva you know how I know you don't care about anyone's time? I have wasted hours because of this issue and I still came here to report it. You spent less than 30 seconds reading it before you closed it. Thanks for nothing. |
He closed it because you your self said that there already are reported issues with this problem.. Instead of creating yet another issue.. post your findings/suggestions/thoughts in a already existing issue. |
I didn't report it. Someone else did and that thread is closed too. I
think it's titled something like "Webstorm causes hmr to reload". It was
webstorm specific. But this raises another problem, does a ticket really
deserve to be closed without referencing the duplicate? Any why is it the
reporter's responsibility to know every search term in order to find it?
…On Tue, Oct 17, 2017 at 11:45 PM, Markus Thiel ***@***.***> wrote:
He closed it because you your self said that there already are reported
issues with this problem..
Instead of creating yet another issue.. post your
findings/suggestions/thoughts in a already existing issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8033 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AX5Xbjp54GNhdAZAEocHCKTCskL6NRnpks5stZ5_gaJpZM4P3qfe>
.
--
CONFIDENTIALITY NOTICE: The contents of this email message and any
attachments are intended solely for the addressee(s) and may contain
confidential and/or privileged information and may be legally protected
from disclosure. It is then shared with tech companies, bots, hackers,
government agencies, and marketers. The security of this message is none,
and it may be shared on Instagram at anytime. If you are OK with this,
please respond. There isn't really any security or privacy anywhere. If
you disagree you may want to go camping and talk to people face-to-face
like in old times.
|
Hi @megamindbrian, Could you point us to the issue that's been closed? In particular, HMR refreshing issues. If it's still happening we shouldn't have closed it, and we can reopen it. I cannot find anything with Webstorm that seems to be about HMR refreshing. Thanks. |
Sure, I wanted to prune through my browser history all morning anyways. Here are related issues, I spent hours trying to solve this on Oct 3 and no one had a good solution: Looks like the latest version fixed it so it can stay closed. |
I must not be the only person making noise. Maybe my expectations are too high for this house of cards. |
Please view this email in an HTML compatible email client.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
https://github.com/angular/angular-cli/search?q=refresh&type=Issues&utf8=%E2%9C%93
This is already on here, I'm just too lazy to look it up. Angular-cli in "Watch" mode refreshes excessively. please fix this.
The text was updated successfully, but these errors were encountered: