Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't disable typescriptMismatch warning #7678

Closed
xnnkmd opened this issue Sep 13, 2017 · 2 comments · Fixed by #7836
Closed

Can't disable typescriptMismatch warning #7678

xnnkmd opened this issue Sep 13, 2017 · 2 comments · Fixed by #7836
Assignees
Labels
feature Issue that requests a new feature P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@xnnkmd
Copy link

xnnkmd commented Sep 13, 2017

Bug Report or Feature Request (mark with an x)

- [x ] bug report -> please search issues before submitting
- [ ] feature request

When want to disable the typescriptMismatch warning on a project-basis so it only affects a particular project and the warning is automatically disabled for other developers. Hence, I want to disable it from within the angular-cli config file.

Versions.

@angular/cli: 1.4.1
node: 7.7.1
os: win32 x64
@angular/common: 4.3.6
@angular/compiler: 4.3.6
@angular/core: 4.3.6
@angular/forms: 4.3.6
@angular/http: 4.3.6
@angular/platform-browser: 4.3.6
@angular/platform-browser-dynamic: 4.3.6
@angular/router: 4.3.6
@angular/cli: 1.4.1
@angular/compiler-cli: 4.3.6
typescript: 2.5.2

Repro steps.

Setup angular project to use latest typescript.

Add this to .angular-cli.json:

    "warnings": {
        "typescriptMismatch": false
    }

run "ng build"

The output given by the failure.

@angular/[email protected] requires typescript@'>=2.1.0 <2.4.0' but 2.5.2 was found instead.
Using this version can result in undefined behaviour and difficult to debug problems.

Please run the following command to install a compatible version of TypeScript.

npm install typescript@'>=2.1.0 <2.4.0'

To disable this warning run "ng set --global warnings.typescriptMismatch=false".

Desired functionality.

When I disable the typescriptMismatch warning in .angular-cli.json I expect the warning to disappear when running ng build.

Mention any other details that might be useful.

It might be possible to disable the warning instead by setting a global flag but I want something that only affects a single project yet is shared with other developers automatically. Setting a global flag won't do that.

@Brocco Brocco added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity3: broken labels Sep 22, 2017
@filipesilva
Copy link
Contributor

Currently we only support disabling it globally, but I agree it would be good to work locally as well. Will implement.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Issue that requests a new feature P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants