Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PathLocationStrategy out of the box #66

Closed
IgorMinar opened this issue Nov 22, 2015 · 5 comments
Closed

Support PathLocationStrategy out of the box #66

IgorMinar opened this issue Nov 22, 2015 · 5 comments
Assignees
Labels
feature Issue that requests a new feature help wanted

Comments

@IgorMinar
Copy link
Contributor

PathLocationStrategy requires server rewrites to be setup. We should do this OOB since we want to promote the use of this strategy over hash location strategy.

@intellix
Copy link
Contributor

I've investigated this somewhat and it seems that ember-cli uses middleware for SPA support: https://github.com/ember-cli/ember-cli/blob/master/lib/tasks/server/middleware/history-support/index.js#L22

We just need a blueprint for an environment file containing a baseURL and locationType of auto and it'll work: https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/config/environment.js

@IgorMinar
Copy link
Contributor Author

@intellix would you like to send us a PR?

@cironunes
Copy link
Member

@IgorMinar, he sent this one: #121

@petebacondarwin
Copy link
Contributor

Closed by #121

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Issue that requests a new feature help wanted
Projects
None yet
Development

No branches or pull requests

4 participants