-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@ngtools/webpack v.1.2.6 - not building lazy routes #4346
Comments
yes we see the same issue in latest .28-3 |
@born2net AFAIK, I was able to fix this by changing the configuration of CommonChunksPlugin, which I originally copied from angular2-webpack-starter, this way: new CommonsChunkPlugin({
name: 'polyfills',
chunks: ['polyfills']
}),
// This enables tree shaking of the vendor modules
new CommonsChunkPlugin({
name: 'vendor',
chunks: ['main'],
minChunks: module => /node_modules/.test(module.resource)
}),
// Specify the correct order the scripts will be injected in
new CommonsChunkPlugin({
name: ['polyfills', 'vendor'].reverse()
}), and by expliciting writing a vendor.bundle file. |
Seeing the same here |
@unsafecode I am using cli so can't access webpack config |
To the best of my knowledge, this does not happen on the latest release ( If you are still experiencing this please open a new issue with a simple repro we can follow. We test the lazy route generation on our test suites, so if it's broken we really need a simple repro to investigate the particulars of your scenario. |
#4431 is still an issue that's related to this. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
OS?
Versions.
[email protected]
[email protected]
@ngtools/[email protected]
[email protected]
[email protected]
not an angular-cli project
Repro steps.
After upgrading from v1.2.3 to v1.2.6, all the lazy routes chunks are missing from output. With v1.2.3, they were all included in the main bundle - which was still a mistake, but more manageable.
The log given by the failure.
No actual failure: other chunks are simply missing in output.
Mention any other details that might be useful.
app.routes.ts
format:The text was updated successfully, but these errors were encountered: