Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Remove component generation when generating modules w/ routing #4209

Closed
Brocco opened this issue Jan 24, 2017 · 1 comment · Fixed by #4706
Closed

Feature Request: Remove component generation when generating modules w/ routing #4209

Brocco opened this issue Jan 24, 2017 · 1 comment · Fixed by #4706
Assignees
@Brocco

Comments

@Brocco
Copy link
Contributor

Brocco commented Jan 24, 2017

Currently when you generate a module using --routing a component is generated with the same name as the module. While this could be helpful at times, there is no way of configuring anything about the generated module.

  • name?
  • inline style/template?
  • flat?
  • spec file?

I suggest removing the component generation from module generation completely.

Users can get the same experience by running one extra command while gaining finer control over what is being generated.
@Brocco Brocco mentioned this issue Jan 24, 2017
Closed
@Brocco Brocco self-assigned this Feb 14, 2017
Brocco added a commit to Brocco/angular-cli that referenced this issue Feb 15, 2017
@Brocco
fix(@angular/cli): remove component generation from module generation
5814bbb 
Fixes angular#4209

BREAKING CHANGE: Generating a module with routing will no longer generate an associated component.
@Brocco Brocco mentioned this issue Feb 15, 2017
Merged
Brocco added a commit to Brocco/angular-cli that referenced this issue Feb 15, 2017
@Brocco
fix(@angular/cli): remove component generation from module generation
5f3b11f 
Fixes angular#4209

BREAKING CHANGE: Generating a module with routing will no longer generate an associated component.
Brocco added a commit to Brocco/angular-cli that referenced this issue Feb 15, 2017
@Brocco
fix(@angular/cli): remove component generation from module generation
6824ccb 
Fixes angular#4209

BREAKING CHANGE: Generating a module with routing will no longer generate an associated component.
Brocco added a commit to Brocco/angular-cli that referenced this issue Feb 16, 2017
@Brocco
fix(@angular/cli): remove component generation from module generation
1e3b115 
Fixes angular#4209

BREAKING CHANGE: Generating a module with routing will no longer generate an associated component.
Brocco added a commit that referenced this issue Feb 16, 2017
@Brocco
fix(@angular/cli): remove component generation from module generation (…
9db71d8 
…#4706)

Fixes #4209

BREAKING CHANGE: Generating a module with routing will no longer generate an associated component.
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this issue Apr 12, 2017
@Brocco
fix(@angular/cli): remove component generation from module generation (…
977784c 
…angular#4706)

Fixes angular#4209

BREAKING CHANGE: Generating a module with routing will no longer generate an associated component.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brocco Brocco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@angular/cli): remove component generation from module generation Brocco/angular-cli
1 participant
@Brocco