Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng doc <keyword> uses wrong querystring parameter name #3363

Closed
johnpapa opened this issue Dec 3, 2016 · 3 comments
Closed

ng doc <keyword> uses wrong querystring parameter name #3363

johnpapa opened this issue Dec 3, 2016 · 3 comments

Comments

@johnpapa
Copy link
Contributor

johnpapa commented Dec 3, 2016

OS?

Mac OSX Sierra

Versions.

angular-cli: 1.0.0-beta.21
node: 6.9.1
os: darwin x64

Repro steps.

ng doc pipe

Mention any other details that might be useful.

This opens https://angular.io/docs/ts/latest/api/#!?apiFilter=pipe but it appears it should open https://angular.io/docs/ts/latest/api/#!?query=pipe

Perhaps the querystring parameter name changed from apiFilter to query

@johnpapa
Copy link
Contributor Author

johnpapa commented Dec 3, 2016

cc @Brocco

@baruchvlz
Copy link
Contributor

baruchvlz commented Dec 4, 2016

I know this is probably very low priority but I'm not a great developer and I do want to help where I can. With that said, this seems to work fine with apiFilter but once inside the the API Reference page and you change the search input, the url changes to something like so

https://angular.io/docs/ts/latest/api/#!?apiFilter=component&query=commonmodule

Not the prettiest URL but it works.

MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this issue Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants