Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github-pages:deploy doesn't clean up obsolete files #3081

Closed
rongchaua opened this issue Nov 9, 2016 · 2 comments · Fixed by #3333
Closed

github-pages:deploy doesn't clean up obsolete files #3081

rongchaua opened this issue Nov 9, 2016 · 2 comments · Fixed by #3333
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix

Comments

@rongchaua
Copy link

rongchaua commented Nov 9, 2016 •
edited
Loading

Hi,
I would like to ask if the command "ng github-pages:deploy" should clean up the "dist" folder when deploying? I see the obsolete files aren't deleted from "gh-pages" branch.

1

The "gh-pages" branch keeps growing up with these obsolete files. Should I clean up the "gh-pages" manually?
@filipesilva
Copy link
Contributor

No, you shouldn't have to do it manually. It's a bug.

@filipesilva filipesilva added command: deploy P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Nov 21, 2016
rolyatsats added a commit to rolyatsats/angular-cli that referenced this issue Dec 1, 2016
@rolyatsats
fix(deploy): clean up gh-pages obsolete files (angular#3081)
414b371 
Prevents the gh-pages branch from growing indefinitely by cleaning up before copying new files.
Fixes angular#3081
@rolyatsats rolyatsats mentioned this issue Dec 1, 2016
Merged
rolyatsats added a commit to rolyatsats/angular-cli that referenced this issue Dec 1, 2016
@rolyatsats
fix(deploy): clean up gh-pages obsolete files (angular#3081)
9fb8863 
Prevents the gh-pages branch from growing indefinitely by cleaning up before copying new files.

Fixes angular#3081
rolyatsats added a commit to rolyatsats/angular-cli that referenced this issue Dec 1, 2016
@rolyatsats
fix(deploy): clean up gh-pages obsolete files (angular#3081)
ecdaee7 
Prevents the gh-pages branch from growing indefinitely by cleaning up before copying new files.

Fixes angular#3081
hansl pushed a commit that referenced this issue Dec 3, 2016
@rolyatsats @hansl
fix(deploy): clean up gh-pages obsolete files (#3081) (#3333)
51869fb 
Prevents the gh-pages branch from growing indefinitely by cleaning up before copying new files.

Fixes #3081
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this issue Feb 9, 2017
@rolyatsats @MRHarrison
fix(deploy): clean up gh-pages obsolete files (angular#3081) (angular…
8e93cce 
…#3333)

Prevents the gh-pages branch from growing indefinitely by cleaning up before copying new files.

Fixes angular#3081
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deploy): clean up gh-pages obsolete files (#3081) rolyatsats/angular-cli
2 participants
@filipesilva @rongchaua