-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch HttpClient + signals is not triggering cdr #25985
Comments
Well, thank you for reporting that, this.client
.get('https://random-data-api.com/api/beer/random_beer')
.subscribe(() => {
NgZone.assertInAngularZone();
}); Fails miserably when using the Edit: This bug only happens with the |
import { ChangeDetectorRef } from '@angular/core'; // Inside your component constructor or method // Inside your HTTP request subscription or switchMap |
cc @alan-agius4 If you have any idea why the builder changes the behaviour we can observe here. Edit: it's getting weirder every time i try to look into it, it seems to be caching related in serve mode.
|
Yeah, I know what is going on. I'll open a PR later today. |
…using vite dev-server with caching enabled Prior to this change, async/await in external packages were not being correctly downlevelled when using vite dev-server with cache enabled. Closes angular#25985
…using vite dev-server with caching enabled Prior to this change, async/await in external packages were not being correctly downlevelled when using vite dev-server with cache enabled. Closes #25985
…using vite dev-server with caching enabled Prior to this change, async/await in external packages were not being correctly downlevelled when using vite dev-server with cache enabled.t checkout Closes angular#25985 (cherry picked from commit 968ee34)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Which @angular/* package(s) are the source of the bug?
common
Is this a regression?
Yes
Description
HttpClient
withFetch()
will not trigger CDR with nested queries coming fromswitchMap
Please provide a link to a minimal reproduction of the bug
https://stackblitz.com/edit/angular-at-wvr9ue?file=src%2Fmain.ts
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in (run
ng version
)Anything else?
No response
The text was updated successfully, but these errors were encountered: