Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schematics issue #24817

Closed
1 task
szqsy17 opened this issue Mar 7, 2023 · 1 comment · Fixed by #24818
Closed
1 task

schematics issue #24817

szqsy17 opened this issue Mar 7, 2023 · 1 comment · Fixed by #24818
Assignees
@alan-agius4
Labels
area: @angular-devkit/schematics-cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken

Comments

@szqsy17
Copy link

szqsy17 commented Mar 7, 2023

Command

other

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

Subject: Schematics

Can not input number in shell, the shell prompts "must be number".

Minimal Reproduction

The function just outputs the options.
image

Use "x-prompt" for property "age" and define type "number".
image

Test in shell, interactive input is invalid.
image

Test in shell, arguments input is valid.
image

Exception or Error

No response

Your Environment

@angular-devkit/[email protected]

Anything else relevant?

No response
@alan-agius4 alan-agius4 added area: @angular-devkit/schematics-cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken labels Mar 7, 2023
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Mar 7, 2023
@alan-agius4
fix(@angular-devkit/schematics-cli): correctly transform numbers from…
ae791e9 
… prompts

This commits ports the same logic from the `@angular/cli` (https://github.com/angular/angular-cli/blob/693d78b80de9e91bd5313353ea5c524742196e0a/packages/angular/cli/src/command-builder/schematics-command-module.ts#L183-L211) to correctly handle numbers in prompts.

Closes angular#24817
@alan-agius4 alan-agius4 mentioned this issue Mar 7, 2023
Merged
@alan-agius4 alan-agius4 self-assigned this Mar 7, 2023
angular-robot bot pushed a commit that referenced this issue Mar 7, 2023
@alan-agius4 @angular-robot
fix(@angular-devkit/schematics-cli): correctly transform numbers from…
d15d44d 
… prompts

This commits ports the same logic from the `@angular/cli` (https://github.com/angular/angular-cli/blob/693d78b80de9e91bd5313353ea5c524742196e0a/packages/angular/cli/src/command-builder/schematics-command-module.ts#L183-L211) to correctly handle numbers in prompts.

Closes #24817
angular-robot bot pushed a commit that referenced this issue Mar 7, 2023
@alan-agius4 @clydin
fix(@angular-devkit/schematics-cli): correctly transform numbers from…
dfd03aa 
… prompts

This commits ports the same logic from the `@angular/cli` (https://github.com/angular/angular-cli/blob/693d78b80de9e91bd5313353ea5c524742196e0a/packages/angular/cli/src/command-builder/schematics-command-module.ts#L183-L211) to correctly handle numbers in prompts.

Closes #24817

(cherry picked from commit d15d44d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alan-agius4 alan-agius4

Labels
area: @angular-devkit/schematics-cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken
Projects
None yet
Milestone
No milestone
2 participants
@alan-agius4 @szqsy17