Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong packages when running ng update #22087

Closed
ties-s opened this issue Nov 4, 2021 · 3 comments · Fixed by #22128
Closed

Wrong packages when running ng update #22087

ties-s opened this issue Nov 4, 2021 · 3 comments · Fixed by #22128

Comments

@ties-s
Copy link

ties-s commented Nov 4, 2021

Which @angular/* package(s) are the source of the bug?

upgrade

Is this a regression?

Yes

Description

When running ng update it lists @nguniversal/aspnetcore-engine while I'm using universal with express only (which isn't listed)

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

PROJECT_PATH  beta ✔  
▶ ng update
The installed local Angular CLI version is older than the latest stable version.
Installing a temporary version to perform the update.
✔ Package successfully installed.
Using package manager: 'npm'
Collecting installed dependencies...
Found 81 dependencies.
    We analyzed your package.json, there are some packages to update:
    
      Name                                    Version                  Command to update
     -------------------------------------------------------------------------------------
      @angular-eslint/schematics              12.5.0 -> 12.6.1         ng update @angular-eslint/schematics
      @angular/cdk                            12.2.8 -> 13.0.0         ng update @angular/cdk
      @angular/cli                            12.2.7 -> 13.0.1         ng update @angular/cli
      @angular/core                           12.2.8 -> 13.0.0         ng update @angular/core
      @angular/google-maps                    12.2.8 -> 13.0.0         ng update @angular/google-maps
      @angular/material                       12.2.8 -> 13.0.0         ng update @angular/material
      @nguniversal/aspnetcore-engine          12.1.1 -> 13.0.0         ng update @nguniversal/aspnetcore-engine
    
    There might be additional packages which don't provide 'ng update' capabilities that are outdated.
    You can update the additional packages by running the update command of your package manager.

PROJECT_PATH  beta ✔ 
▶ npm ls @nguniversal/aspnetcore-engine
[email protected] PROJECT_PATH
└── (empty)

Please provide the environment you discovered this bug in

Angular CLI: 12.2.7
Node: 16.11.1 (Unsupported)
Package Manager: npm 8.1.2
OS: darwin arm64

Angular: 12.2.8
... animations, cdk, common, compiler, compiler-cli, core, forms
... google-maps, material, platform-browser
... platform-browser-dynamic, platform-server, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1202.7
@angular-devkit/build-angular   12.2.7
@angular-devkit/core            12.2.7
@angular-devkit/schematics      12.2.7
@angular/cli                    12.2.7
@nguniversal/builders           12.1.1
@nguniversal/common             12.1.1
@nguniversal/express-engine     12.1.1
@schematics/angular             12.2.7
rxjs                            6.6.7
typescript                      4.3.5

Anything else?

No response

@alan-agius4
Copy link
Collaborator

@ties-s, can you please share your package.json? Thanks.

@ties-s
Copy link
Author

ties-s commented Nov 4, 2021

  "dependencies": {
    "@angular/animations": "^13.0.0",
    "@angular/cdk": "^13.0.0",
    "@angular/common": "~13.0.0",
    "@angular/compiler": "~13.0.0",
    "@angular/core": "~13.0.0",
    "@angular/forms": "~13.0.0",
    "@angular/google-maps": "^13.0.0",
    "@angular/material": "^13.0.0",
    "@angular/platform-browser": "~13.0.0",
    "@angular/platform-browser-dynamic": "~13.0.0",
    "@angular/platform-server": "~13.0.0",
    "@angular/router": "~13.0.0",
    "@auth0/angular-jwt": "^5.0.2",
    "@desqplan/models": "^1.0.0-beta.100",
    "@fortawesome/angular-fontawesome": "^0.9.0",
    "@fortawesome/fontawesome-svg-core": "^1.2.34",
    "@fortawesome/free-brands-svg-icons": "^5.15.2",
    "@fortawesome/pro-duotone-svg-icons": "^5.15.2",
    "@fortawesome/pro-light-svg-icons": "^5.15.2",
    "@fortawesome/pro-regular-svg-icons": "^5.15.2",
    "@fortawesome/pro-solid-svg-icons": "^5.15.2",
    "@nguniversal/common": "^13.0.0",
    "@nguniversal/express-engine": "^13.0.0",
    "@stripe/stripe-js": "^1.15.0",
    "@tiess/tx-model": "^2.0.0-beta.59",
    "bcryptjs": "^2.4.3",
    "bson": "^4.4.0",
    "buffer": "^5.7.1",
    "chart.js": "^3.5.1",
    "chartjs-adapter-luxon": "^1.1.0",
    "cookie-parser": "^1.4.5",
    "express": "^4.15.2",
    "luxon": "^2.0.2",
    "ng-qrcode": "^5.0.0",
    "ngx-webstorage-service": "^4.1.0",
    "prettier": "2.2.1",
    "query-string": "^7.0.0",
    "reflect-metadata": "^0.1.13",
    "rxjs": "7.4",
    "tslib": "^2.0.0",
    "util": "^0.12.4",
    "zone.js": "~0.11.4"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~13.0.1",
    "@angular-eslint/builder": "12.6.1",
    "@angular-eslint/eslint-plugin": "12.6.1",
    "@angular-eslint/eslint-plugin-template": "12.6.1",
    "@angular-eslint/schematics": "12.6.1",
    "@angular-eslint/template-parser": "12.3.1",
    "@angular/cli": "^13.0.1",
    "@angular/compiler-cli": "~13.0.0",
    "@nguniversal/builders": "^13.0.0",
    "@types/cookie-parser": "^1.4.2",
    "@types/express": "^4.17.12",
    "@types/jasmine": "~3.6.0",
    "@types/luxon": "^2.0.5",
    "@types/node": "^12.11.1",
    "@typescript-eslint/eslint-plugin": "4.28.2",
    "@typescript-eslint/parser": "4.28.2",
    "eslint": "^7.26.0",
    "eslint-plugin-import": "latest",
    "eslint-plugin-jsdoc": "latest",
    "eslint-plugin-prefer-arrow": "latest",
    "eslint-plugin-react": "latest",
    "husky": "^6.0.0",
    "jasmine-core": "~3.7.0",
    "jasmine-spec-reporter": "~5.0.0",
    "karma": "~6.3.0",
    "karma-chrome-launcher": "~3.1.0",
    "karma-coverage": "~2.0.3",
    "karma-jasmine": "~4.0.0",
    "karma-jasmine-html-reporter": "~1.5.0",
    "lint-staged": "^10.5.4",
    "nodemon": "^2.0.7",
    "protractor": "~7.0.0",
    "stylelint": "^13.13.1",
    "stylelint-config-prettier": "^8.0.2",
    "stylelint-config-standard": "^22.0.0",
    "stylelint-scss": "^3.20.1",
    "ts-node": "~8.3.0",
    "tslint-config-prettier": "^1.18.0",
    "typescript": "4.4.4"
  },

@alan-agius4 alan-agius4 transferred this issue from angular/angular Nov 4, 2021
@alan-agius4 alan-agius4 added ng update DX area: @angular/cli needs: investigation Requires some digging to determine if action is needed labels Nov 4, 2021
@ngbot ngbot bot modified the milestone: needsTriage Nov 4, 2021
@clydin clydin removed the needs: investigation Requires some digging to determine if action is needed label Nov 9, 2021
clydin pushed a commit that referenced this issue Nov 9, 2021
…tput

With this change we favor the `packageGroupName` name when specified and only fallback to use the first item in in the `packageGroup` array when it is not specified.

Closes #22087

(cherry picked from commit b7b1325)
clydin pushed a commit that referenced this issue Nov 9, 2021
…tput

With this change we favor the `packageGroupName` name when specified and only fallback to use the first item in in the `packageGroup` array when it is not specified.

Closes #22087
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants