Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding web worker via "ng generate webWorker" does not generate differential builds #16275

Closed
2 of 15 tasks
joshcomley opened this issue Nov 24, 2019 · 1 comment · Fixed by #16290
Closed
2 of 15 tasks
Labels
Milestone

Comments

@joshcomley
Copy link

🐞 Bug report

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • xi18n
  • run
  • config
  • help
  • version
  • doc

Is this a regression?

Unsure, I've only just encountered a scenario that would reveal this bug.

Description

Differential builds are not generated for web workers, only es2015.

2019-11-24 11_58_26-NgWorkerEs5Test

🔬 Minimal Reproduction

  • Step 1
    ng new NgWorkerDiffTest --routing=false --style=scss & cd NgWorkerDiffTest & ng generate webWorker MyWorker
  • Step 2
    Modify app.component.ts to include:

    if (typeof Worker !== "undefined") {
      const worker = new Worker("./my-worker.worker", { type: "module" });
    }

  • Step 3
    ng build or ng build --prod - neither will produce anything but es2015 for the worker.

🌍 Your Environment




Angular CLI: 9.0.0-rc.3
Node: 12.12.0
OS: win32 x64
Angular:
...

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.900.0-rc.3
@angular-devkit/core         9.0.0-rc.3
@angular-devkit/schematics   9.0.0-rc.3
@schematics/angular          9.0.0-rc.3
@schematics/update           0.900.0-rc.3
rxjs                         6.5.3

Anything else relevant?

In a way - IE11 will fail to load workers due to syntax errors.

@ngbot ngbot bot modified the milestone: needsTriage Nov 24, 2019
@alan-agius4 alan-agius4 added freq1: low Only reported by a handful of users who observe it rarely type: bug/fix labels Nov 24, 2019
@manughub manughub modified the milestones: v9-candidates, v9-blockers Nov 26, 2019
@manughub manughub assigned manughub and clydin and unassigned manughub Nov 26, 2019
clydin added a commit to clydin/angular-cli that referenced this issue Nov 26, 2019
clydin added a commit to clydin/angular-cli that referenced this issue Nov 27, 2019
clydin added a commit to clydin/angular-cli that referenced this issue Nov 27, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 2, 2020
@clydin clydin removed their assignment Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants