Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed migration prints confusing message about git HEAD #16031

Closed
filipesilva opened this issue Nov 1, 2019 · 1 comment · Fixed by #16039
Closed

Failed migration prints confusing message about git HEAD #16031

filipesilva opened this issue Nov 1, 2019 · 1 comment · Fixed by #16039

Comments

@filipesilva
Copy link
Contributor

This issue impacts 9.0.0-rc.0 and happened while updating https://github.com/johannesjo/super-productivity.

A failed migration can show the following message:

× Package install failed, see above.
The update failed. See above.
git HEAD was at 85f08a4d93e684566f751e38e2a2feffe0194cd9 before migrations.
×  Migration failed. See above for further details.

This message is confusing because it is not clear what to do with the message provided. This message enabled users that are proficient with git to go back to a previous commit. Less proficient users will not be able to interpret the purpose of the message.

Additionally, the message seems to indicate the last commit before the migrations. But this is incorrect, as this commit was that of the immediately previous migration:

* 558e5436 (HEAD -> update-9) update steps
* ec5e3201 migrate workspace for @angular/[email protected]
* 85f08a4d migrate workspace for @angular/[email protected]
* 73e3ee1d Angular CLI update
* a06b9c06 update steps (before migrations)

To go back to a point before all the migrations a user would need to revert back to a06b9c06 instead.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant