Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ng add does not respect version tags on repeat calls #16029

Closed
filipesilva opened this issue Nov 1, 2019 · 1 comment · Fixed by #16040
Closed

ng add does not respect version tags on repeat calls #16029

filipesilva opened this issue Nov 1, 2019 · 1 comment · Fixed by #16040
Labels
area: @angular/cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Milestone
v9-candidates

Comments

@filipesilva
Copy link
Contributor

This issue impacts 9.0.0-rc.0 and happened while updating https://github.com/SAP/cloud-commerce-spartacus-storefront.

Attempting to use ng add package-name@version after a failed ng add package-name (such as #16028) will not use the selected version. It will instead attempt to re-add the already installed package.
@filipesilva filipesilva added type: bug/fix freq1: low Only reported by a handful of users who observe it rarely severity3: broken area: @angular/cli labels Nov 1, 2019
@filipesilva filipesilva added this to the 9.0.x milestone Nov 1, 2019
clydin added a commit to clydin/angular-cli that referenced this issue Nov 2, 2019
@clydin
fix(@angular/cli): verify package specifier when adding a package
8fcbdb9 
Fixes angular#16029
@clydin clydin mentioned this issue Nov 2, 2019
Merged
vikerman pushed a commit that referenced this issue Nov 4, 2019
@clydin @vikerman
fix(@angular/cli): verify package specifier when adding a package
3f57956 
Fixes #16029
vikerman pushed a commit that referenced this issue Nov 4, 2019
@clydin @vikerman
fix(@angular/cli): verify package specifier when adding a package
b80f7fe 
Fixes #16029
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: @angular/cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Projects
None yet
Milestone
v9-candidates
Development

Successfully merging a pull request may close this issue.

fix(@angular/cli): verify package specifier when adding a package clydin/angular-cli
1 participant
@filipesilva