Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics question prevents update to v9 #16012

Closed
DeborahK opened this issue Nov 1, 2019 · 4 comments · Fixed by #16038
Closed

Analytics question prevents update to v9 #16012

DeborahK opened this issue Nov 1, 2019 · 4 comments · Fixed by #16038

Comments

@DeborahK
Copy link
Contributor

DeborahK commented Nov 1, 2019

🐞 bug report

Affected Package

Is this a regression?

Description

When selecting "yes" OR "no" for sharing anonymous usage data, it modifies the angular.json file, adding an analytics entry. This dirties the repository, preventing the update from continuing.

🔬 Minimal Reproduction

  1. ng update @angular/cli @angular/core --next

  2. Answer Y to " Would you like to share anonymous usage data..."

  3. Result:

"Thank you for sharing anonymous usage data. Would you change your mind, the following
command will disable this feature entirely:

ng analytics project off

Repository is not clean. Please commit or stash any changes before updating."

🔥 Exception or Error




Repository is not clean. Please commit or stash any changes before updating. 

🌍 Your Environment

Angular Version:



8.1.3

Anything else relevant?

@DeborahK DeborahK changed the title Saying Yes to Analytics prevents update to v9 Analytics question prevents update to v9 Nov 1, 2019
@DeborahK
Copy link
Contributor Author

DeborahK commented Nov 1, 2019

Using --allow-dirty resolves the issue ... but if this is a requirement to make the update process work, it should be added to the required update steps.

@AndrewKushnir
Copy link

Hi @DeborahK, thanks for reporting this. I'm moving this ticket to CLI team repo for further investigation. Thank you.

@AndrewKushnir AndrewKushnir transferred this issue from angular/angular Nov 1, 2019
@alan-agius4
Copy link
Collaborator

alan-agius4 commented Nov 1, 2019

Can you please provide the full output of ng version prior of running ng update?

To be clear you should not be using --allow-dirty.

Thanks

@ngbot ngbot bot added this to the needsTriage milestone Nov 1, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Nov 1, 2019
@filipesilva filipesilva modified the milestones: Backlog, 9.0.x Nov 1, 2019
@alan-agius4 alan-agius4 added area: docs Related to the documentation and removed type: bug/fix labels Nov 1, 2019
clydin added a commit to clydin/angular-cli that referenced this issue Nov 2, 2019
The prompt will cause the workspace configuration file to be updated which can result in an unclean repository.

Fixes angular#16012
vikerman pushed a commit that referenced this issue Nov 4, 2019
The prompt will cause the workspace configuration file to be updated which can result in an unclean repository.

Fixes #16012
vikerman pushed a commit that referenced this issue Nov 4, 2019
The prompt will cause the workspace configuration file to be updated which can result in an unclean repository.

Fixes #16012
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants