Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include @angular/pwa in ng update #15764

Closed
sebaherrera opened this issue Oct 4, 2019 · 3 comments · Fixed by #15815
Closed

Include @angular/pwa in ng update #15764

sebaherrera opened this issue Oct 4, 2019 · 3 comments · Fixed by #15815
Labels
area: @angular/cli area: @angular/pwa
Milestone
needsTriage

Comments

@sebaherrera
Copy link

🚀 Feature request

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [X ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Description

Update @angular/pwa via ng update

Describe the solution you'd like

Hi. Since @angular/pwa is updated frequently alongside @angular/cli, it would be very useful to update both packages via ng update, which also increments consistency with another packages behavior. Thanks.

Describe alternatives you've considered

Alternative is to update @angular/cli and then run npm update for @angular/pwa
@alan-agius4
Copy link
Collaborator

alan-agius4 commented Oct 4, 2019 •
edited
Loading

Strictly speaking @angular/pwa is not needed as a dependency. This is because the pwa package is a schematic and is only used once when adding pwa capabilities to your application. After that, this package is not used anymore.

@sebaherrera
Copy link
Author

Interesting. I didn't know that. Thank you.

@ngbot ngbot bot added this to the needsTriage milestone Oct 4, 2019
@alan-agius4 alan-agius4 mentioned this issue Oct 11, 2019
Merged
vikerman pushed a commit that referenced this issue Oct 14, 2019
@alan-agius4 @vikerman
feat(@angular/cli): add support for ng-add packages that should not b…
d133ba6 
…e saved as `dependencies`

With this change the CLI offers a way for a package authors to specify if during `ng add` the package should be saved as a `dependencies`, `devDependencies` or not saved at all.

Such config needs to be specified in `package.json`

Example:
```json
  "ng-add": {
    "save": false
  }
```

Possible values are;
- false - Don't add the package to `package.json`
- true - Add the package to the `dependencies`
- `dependencies` - Add the package to the `dependencies`
- `devDependencies` - Add the package to the `devDependencies`

Closes #12003 , closes #15764 and closes #13237
vikerman pushed a commit that referenced this issue Oct 14, 2019
@alan-agius4 @vikerman
feat(@schematics/angular): remove @angular/pwa from depedencies
a7f977f 
`@angular/pwa` is not needed as a dependency. This is because the pwa package is a schematic and is only used once when adding pwa capabilities to your application. After that, this package is not used anymore.

Closes #15764
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: @angular/cli area: @angular/pwa
Projects
None yet
Milestone
needsTriage
Development

Successfully merging a pull request may close this issue.

feat(@angular/cli): add support for ng-add packages that should not b…
2 participants
@alan-agius4 @sebaherrera