Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcemap with prod build and differential loading does not work with update to 8.3.0 #15460

Closed
james-criscuolo opened this issue Aug 27, 2019 · 2 comments · Fixed by #15461
Closed

Comments

@james-criscuolo
Copy link

🐞 Bug report

Command (mark with an x)

- [ ] new
- [ X ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

Yes, the previous version in which this bug was not present was: 8.2.2 (specifically @angular-devkit/build-angular 0.802.2)

Description

The sourcemap comment is missing from main-es2015..js when doing a production build with sourceMaps turned on. main-es5..js

🔬 Minimal Reproduction

🔥 Exception or Error




ng new myApp
//I dont think these options matter, but i turned on angular routing and chose scss
cd myApp
emacs angular.json
// only instance of "sourceMap" in the file must change from false to true
ng build myApp -c production
emacs dist/myApp/main-es2015.hash.js
// bottom of file has no sourcemap indicator
emacs dist/myApp/main-es5.hash.js
// bottom of file has the sourcemap indicator

🌍 Your Environment



 ~/newAngularApp   master ●  ng version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/


Angular CLI: 8.3.0
Node: 10.16.0
OS: darwin x64
Angular: 8.2.3
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.803.0
@angular-devkit/build-angular     0.803.0
@angular-devkit/build-optimizer   0.803.0
@angular-devkit/build-webpack     0.803.0
@angular-devkit/core              8.3.0
@angular-devkit/schematics        8.3.0
@angular/cli                      8.3.0
@ngtools/webpack                  8.3.0
@schematics/angular               8.3.0
@schematics/update                0.803.0
rxjs                              6.4.0
typescript                        3.5.3
webpack                           4.39.2

Anything else relevant?

@Splaktar
Copy link
Member

Splaktar commented Aug 28, 2019

I just ran into this as well using

Angular CLI: 9.0.0-next.0
Node: 12.3.0
OS: darwin x64
Angular: 9.0.0-next.3
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
... service-worker

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.0-next.0
@angular-devkit/build-angular     0.900.0-next.0
@angular-devkit/build-optimizer   0.900.0-next.0
@angular-devkit/build-webpack     0.900.0-next.0
@angular-devkit/core              9.0.0-next.0
@angular-devkit/schematics        9.0.0-next.0
@angular/cdk                      8.1.4
@angular/cli                      9.0.0-next.0
@angular/fire                     5.2.1
@angular/language-service         8.2.3
@angular/material                 8.1.4
@angular/pwa                      0.900.0-next.0
@ngtools/webpack                  9.0.0-next.0
@schematics/angular               9.0.0-next.0
@schematics/update                0.900.0-next.0
rxjs                              6.5.2
typescript                        3.5.3
webpack                           4.39.2

Manually adding the mapping myself enabled me to get a proper report from source-map-explorer.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.