Skip to content

Commit

Permalink
fix(@schematics/angular): remove IE9/10 from browserslist for new pro…
Browse files Browse the repository at this point in the history
…jects

BREAKING CHANGE:
Deprecated support for IE 9-10 has been removed in Angular 11.
Only IE 9-10 support has been removed. IE 11 is officially supported in Angular 11.
Additional information can be found here: https://v10.angular.io/guide/deprecations#ie-9-10-and-mobile
  • Loading branch information
clydin authored and alan-agius4 committed Sep 25, 2020
1 parent 1b8fabf commit e64ea69
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,5 @@ last 2 Edge major versions
last 2 Safari major versions
last 2 iOS major versions
Firefox ESR<% if (legacyBrowsers) { %>
IE 9-10 # Angular support for IE 9-10 has been deprecated and will be removed as of Angular v11.
IE 11<% } else { %>
not IE 9-10 # Angular support for IE 9-10 has been deprecated and will be removed as of Angular v11. To opt-in, remove the 'not' prefix on this line.
not IE 11 # Angular supports IE 11 only as an opt-in. To opt-in, remove the 'not' prefix on this line.<% } %>
8 changes: 2 additions & 6 deletions packages/schematics/angular/application/index_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -431,25 +431,21 @@ describe('Application Schematic', () => {
});
});

it(`should add support for IE 9-11 in '.browserslistrc' when 'legacyBrowsers' is true`, async () => {
it(`should add support for IE 11 in '.browserslistrc' when 'legacyBrowsers' is true`, async () => {
const options: ApplicationOptions = { ...defaultOptions, legacyBrowsers: true };
const tree = await schematicRunner.runSchematicAsync('application', options, workspaceTree)
.toPromise();
const content = tree.readContent('/projects/foo/.browserslistrc');
expect(content).not.toContain('not IE 11');
expect(content).toContain('IE 11');

expect(content).not.toContain('not IE 9-10');
expect(content).toContain('IE 9-10');
});

it(`should not add support for IE 9-11 in '.browserslistrc' when 'legacyBrowsers' is false`, async () => {
it(`should not add support for IE 11 in '.browserslistrc' when 'legacyBrowsers' is false`, async () => {
const options: ApplicationOptions = { ...defaultOptions, legacyBrowsers: false };
const tree = await schematicRunner.runSchematicAsync('application', options, workspaceTree)
.toPromise();
const content = tree.readContent('/projects/foo/.browserslistrc');
expect(content).toContain('not IE 11');
expect(content).toContain('not IE 9-10');
});

it(`should create kebab-case project folder names with camelCase project name`, async () => {
Expand Down
6 changes: 0 additions & 6 deletions tests/legacy-cli/e2e/assets/protractor-saucelabs.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,6 @@ exports.config = {
version: '13.1',
tunnelIdentifier,
},
{
browserName: 'internet explorer',
platform: 'Windows 8',
version: '10',
tunnelIdentifier,
},
{
browserName: 'internet explorer',
platform: 'Windows 8.1',
Expand Down

0 comments on commit e64ea69

Please sign in to comment.