-
Notifications
You must be signed in to change notification settings - Fork 12k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(@schematics/angular): update
@angular-devkit/build-ng-packagr
w…
…hen migrating Closes #12642
- Loading branch information
1 parent
f3330db
commit da2554a
Showing
4 changed files
with
91 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
packages/schematics/angular/migrations/update-7/devkit-ng-packagr.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/** | ||
* @license | ||
* Copyright Google Inc. All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
import { Rule } from '@angular-devkit/schematics'; | ||
import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks'; | ||
import { addPackageJsonDependency, getPackageJsonDependency } from '../../utility/dependencies'; | ||
import { latestVersions } from '../../utility/latest-versions'; | ||
|
||
export function updateDevkitBuildNgPackagr(): Rule { | ||
return (tree, context) => { | ||
const existing = getPackageJsonDependency(tree, '@angular-devkit/build-ng-packagr'); | ||
|
||
if (!existing) { | ||
return; | ||
} | ||
|
||
addPackageJsonDependency( | ||
tree, | ||
{ | ||
type: existing.type, | ||
name: '@angular-devkit/build-ng-packagr', | ||
version: latestVersions.DevkitBuildNgPackagr, | ||
overwrite: true, | ||
}, | ||
); | ||
|
||
context.addTask(new NodePackageInstallTask()); | ||
}; | ||
} |
52 changes: 52 additions & 0 deletions
52
packages/schematics/angular/migrations/update-7/devkit-ng-packagr_spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/** | ||
* @license | ||
* Copyright Google Inc. All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
import { EmptyTree } from '@angular-devkit/schematics'; | ||
import { SchematicTestRunner, UnitTestTree } from '@angular-devkit/schematics/testing'; | ||
import { latestVersions } from '../../utility/latest-versions'; | ||
|
||
const oldPkg = ` | ||
{ | ||
"devDependencies": { | ||
"@angular-devkit/build-angular": "0.0.0", | ||
"@angular-devkit/build-ng-packagr": "0.0.0" | ||
} | ||
} | ||
`; | ||
|
||
describe('updateDevkitBuildNgPackagr', () => { | ||
const schematicRunner = new SchematicTestRunner( | ||
'migrations', | ||
require.resolve('../migration-collection.json'), | ||
); | ||
|
||
let tree: UnitTestTree; | ||
|
||
beforeEach(async () => { | ||
tree = new UnitTestTree(new EmptyTree()); | ||
tree = await schematicRunner.runExternalSchematicAsync( | ||
require.resolve('../../collection.json'), 'ng-new', | ||
{ | ||
name: 'migration-test', | ||
version: '1.2.3', | ||
directory: '.', | ||
}, | ||
tree, | ||
).toPromise(); | ||
}); | ||
|
||
it('should work as expected', async () => { | ||
tree.overwrite('/package.json', oldPkg); | ||
const tree2 = await schematicRunner.runSchematicAsync('migration-06', {}, tree.branch()) | ||
.toPromise(); | ||
|
||
const content = tree2.readContent('/package.json'); | ||
const pkg = JSON.parse(content); | ||
expect(pkg.devDependencies['@angular-devkit/build-ng-packagr']) | ||
.toBe(latestVersions.DevkitBuildNgPackagr); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters