Skip to content

Commit

Permalink
test: reduce flakiness of E2E rebuild test
Browse files Browse the repository at this point in the history
The rebuild E2E test now waits for the development server to indicate it
has updated any clients before trying to fetch files. This improves the
reliability of the test when using the application builder.
  • Loading branch information
clydin committed Nov 2, 2024
1 parent 4b30f4e commit cd160c2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/legacy-cli/e2e/tests/basic/rebuild.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { ngServe } from '../../utils/project';

export default async function () {
const esbuild = getGlobalVariable('argv')['esbuild'];
const validBundleRegEx = esbuild ? /complete\./ : /Compiled successfully\./;
const validBundleRegEx = esbuild ? /sent to client/ : /Compiled successfully\./;
const lazyBundleRegEx = esbuild ? /chunk-/ : /src_app_lazy_lazy_component_ts\.js/;

// Disable component stylesheet HMR to support page reload based rebuild testing.
Expand Down

0 comments on commit cd160c2

Please sign in to comment.