fix(@angular-devkit/build-optimizer): don't remove ɵɵsetNgModuleScope…

… calls These will be automatically removed after angular/angular#33671 lands because they are in a side-effect free IIFE.
angular · Nov 21, 2019 · 77b3981 · 77b3981
1 parent ed4bf6e
commit 77b3981
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 18 deletions.
diff --git a/packages/angular_devkit/build_optimizer/src/transforms/scrub-file.ts b/packages/angular_devkit/build_optimizer/src/transforms/scrub-file.ts
@@ -18,7 +18,6 @@ export function testScrubFile(content: string) {
     'propDecorators',
     'ctorParameters',
     'ɵsetClassMetadata',
-    'ɵɵsetNgModuleScope',
   ];
 
   return markers.some((marker) => content.indexOf(marker) !== -1);
@@ -313,8 +312,7 @@ function isIvyPrivateCallExpression(exprStmt: ts.ExpressionStatement) {
     return false;
   }
 
-  if (propAccExpr.name.text != 'ɵsetClassMetadata'
-    && propAccExpr.name.text != 'ɵɵsetNgModuleScope') {
+  if (propAccExpr.name.text != 'ɵsetClassMetadata') {
     return false;
   }
 

diff --git a/packages/angular_devkit/build_optimizer/src/transforms/scrub-file_spec.ts b/packages/angular_devkit/build_optimizer/src/transforms/scrub-file_spec.ts
@@ -735,20 +735,5 @@ describe('scrub-file', () => {
       expect(testScrubFile(input)).toBeTruthy();
       expect(tags.oneLine`${transform(input)}`).toEqual(tags.oneLine`${output}`);
     });
-
-    it('removes ɵɵsetNgModuleScope call', () => {
-      const output = tags.stripIndent`
-        import { CommonModule } from '@angular/common';
-        import * as i0 from "@angular/core";
-        ${clazz}
-      `;
-      const input = tags.stripIndent`
-        ${output}
-        /*@__PURE__*/ i0.ɵɵsetNgModuleScope(Clazz, { declarations: [], imports: [CommonModule] });
-      `;
-
-      expect(testScrubFile(input)).toBeTruthy();
-      expect(tags.oneLine`${transform(input)}`).toEqual(tags.oneLine`${output}`);
-    });
   });
 });