Skip to content

Commit

Permalink
fix(@schematics/update): remove update all suggestion message
Browse files Browse the repository at this point in the history
The language within the message specifies that update all will _try_ to update all the packages.  In practice and especially for larger projects, this operation will mostly likely not succeed.  This can lead to the users attempting to use the all option with the force option which has a decent probability to break the project via incorrect peer dependency installation or other incompability version increases (packages that don't follow semver, for instance).

Reference: #14561 (comment)
  • Loading branch information
clydin authored and Keen Yee Liau committed Jun 13, 2019
1 parent 055313c commit 448a8dd
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions packages/schematics/update/update/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -508,10 +508,6 @@ function _usageMessage(
logger.info(' ' + fields.map((x, i) => x.padEnd(pads[i])).join(''));
});

logger.info('\n');
logger.info('There might be additional packages that are outdated.');
logger.info('Run "ng update --all" to try to update all at the same time.\n');

return of<void>(undefined);
}

Expand Down

0 comments on commit 448a8dd

Please sign in to comment.