-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
problem loading ui.scroll.jqlite #72
Comments
Did you include the ui-scroll-jqlite (look here) |
if i add ui-scroll-jqlite as depency,, my app won't load due failed load of ui.scroll.jqlite module. |
some more information. the vendor.js file in the .tmp is not containing the module ui.scroll.jqlite, only the ui.scroll. |
solved my problem in a non elegant way (in my opinion) |
I´m actually having the same issue and for me copying the code into ui.scroll is not an option.. what am I missing? |
Can you post a repro? |
Just installed with npm and used webpack to create my build.js. |
@mackelito it would be nice if you could create a git-repository (or give me a link if it exists) which contains your problem. For I may clone it and fix the issue. |
The problem is that the package only includes |
@chillyistkult You know, "main" property could contain only one module link. And the problem is that ui-scroll has a conditional dependency: jQuery or ui-scroll-jqlite. What solution could be suggested here (except manual builder settings managing)? I really would not wish to include ui-scroll-jqlite source code into ui-scroll.js... |
how about providing it as a separate module? |
@dhilt You are right, there can be only one main file, but normally the library should work without having to care about additional dependencies (that are not automatically resolved). @mackelito @dhilt Of course you could just add the missing dependency manually or (and that would be the best solution) add ui.scroll.jqlite as an independent module to bower and add the dependency to the bower.json of ui.scroll. That way automated build tools will be able to inject all the files that are needed to run ui.scroll. But it's still awkward to have ui.scroll.jqlite as an angular module instead of (like the jquery way) a global function. |
@dhilt just a small question.. what differs the ui-scroll.jqlite from the jqlite in angular? |
ui.scroll.jqlite adds a few methods like element.before and element.after (and others) that are originally not included in angular's jqlite. I guess the reason for @dhilt to maintain an own module just to add this needed methods was to keep the library as lightweight as possible without having a hard dependency on full jquery. |
A new version is released. Now jqLiteExtras service is a part of ui.scroll module. No need to apply it manually. The necessary check (for jQuery presence) and applying are being automatically performed during ui.scroll module run. The ui.scroll.jqlite module is still there, but now it is just an empty stub. It is so for backward compatibility reasons. |
hi there, issue still exists. webpack returns "Can't resolve 'angular-ui-scroll'" thanks ahead. |
The ui.scroll module has no more any dependencies since v1.6.0. The only
thing you need in your app is the "ui.scroll" module dependency. Are you
sure that you have cleaned all ui.scroll.jqlite mentions from your source
code? Or maybe you could share your webpack config with us?
10 Фев 2017 г. 23:22 пользователь "dannydechtiar" <[email protected]>
написал:
… hi there, issue still exists. webpack returns "Can't resolve
'angular-ui-scroll'"
i do see the empty stub (sqlite file).
v1.6.0
thanks ahead.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEKdXJpa9-0AfiHIwmpl9I8W5ESD1cNjks5rbMcHgaJpZM4H3DpR>
.
|
I installed the ui-scroll with the ui-utils.
Even with the simple provided examples i'm getting error : viewport.offset is not function.
I tried to install the ui-scroll directly and now getting the error element.before is not a function
I know the issue is related to the jqlite, but can't add it in my bower. (errors). Where to to load it?
any help would be appreciated.
The text was updated successfully, but these errors were encountered: