feat(uiSrefActive): allow active & active-eq on same element #1999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will allow the usage of both
ui-sref-active
andui-sref-active-eq
on the same element.One use case includes menus with expanding states where a parent element can be both
active
andopen
, such as in this example:When the account child views are active, the parent view should have a class of "open". However, when the parent is active, then the parent element should have both "open" and "active" classes.
This pull request exposes a race condition bug which I have created a separate issue for, #1997. Due to the slight decrease in performance by adding this functionality, the bug is now evident through the failure of one unit test.