Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error in IE 11 #3696

Closed
1 of 3 tasks
Wideweb opened this issue May 14, 2018 · 4 comments
Closed
1 of 3 tasks

Syntax error in IE 11 #3696

Wideweb opened this issue May 14, 2018 · 4 comments

Comments

@Wideweb
Copy link

Wideweb commented May 14, 2018

This is a (check one box):

  • Bug Report
  • Feature Request
  • General Query

My version of UI-Router is: 1.0.17

Bug Report

Current Behavior:

Application fails in IE 11 because of Syntax error in angular-ui-router.js (Line: 989, Column: 11).
There was no such error in version 1.0.15.

Expected Behavior:

Application runs successfully in IE 11

@Nickman87
Copy link
Contributor

          result.push(
            args.map(function(array) {
              return array[i];
            }),
          );
          break;

IE (and other browsers) do not like the trailing comma in function arguments

Nickman87 added a commit to Nickman87/ui-router that referenced this issue May 15, 2018
Less brutal trailing comma's to support mainstream browsers in non minified build.
Fixes angular-ui#3696
@christopherthielen
Copy link
Contributor

As it turns out, this was due to accidentally running prettier on the bundles before publishing to bower. NPM bundles were not affected. See #3693

@christopherthielen
Copy link
Contributor

Also, I just published a new version and it should work as before.

@maximilianschmid
Copy link

tested. now works again. thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants