-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use $templateRequest
instead of $http
when downloading the template from templateUrl
#1882
Comments
Yes!
Not currently. We haven't done a version bump of the suite in a while. I'll get on that later today. |
@nateabele did you get a chance to look into this? |
@matsko I did, yeah. Turns out we actually do run the test suite against 1.3, it just wasn't part of the default build (which I have since fixed... I'll add 1.4 shortly as well). The patch was pretty simple, but it looks like the |
@christopherthielen What's our minimum version for 1.0 gonna be again? |
Would you guys be open to use
$templateRequest
instead of$http
? I tried creating a patch, but it looks like the tests only run using 1.2.$templateRequest
runs with 1.3 only. Is there anything we can do? Do you guys have a different test suite for 1.3 code?I'm trying to fix this bug: angular/angular.js#11492
The text was updated successfully, but these errors were encountered: