Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $templateRequest instead of $http when downloading the template from templateUrl #1882

Closed
matsko opened this issue Apr 14, 2015 · 5 comments
Assignees

Comments

@matsko
Copy link

matsko commented Apr 14, 2015

Would you guys be open to use $templateRequest instead of $http? I tried creating a patch, but it looks like the tests only run using 1.2. $templateRequest runs with 1.3 only. Is there anything we can do? Do you guys have a different test suite for 1.3 code?

I'm trying to fix this bug: angular/angular.js#11492

@nateabele
Copy link
Contributor

Would you guys be open to use $templateRequest instead of $http?

Yes!

Do you guys have a different test suite for 1.3 code?

Not currently. We haven't done a version bump of the suite in a while. I'll get on that later today.

@nateabele nateabele self-assigned this Apr 14, 2015
@matsko
Copy link
Author

matsko commented Apr 20, 2015

@nateabele did you get a chance to look into this?

@nateabele
Copy link
Contributor

@matsko I did, yeah. Turns out we actually do run the test suite against 1.3, it just wasn't part of the default build (which I have since fixed... I'll add 1.4 shortly as well).

The patch was pretty simple, but it looks like the $templateFactory test is hung up in at least two places: differences in the Accept header, and what appears to be a BC-break in the API for $httpBackend. Open to suggestions on how to resolve that.

@nateabele
Copy link
Contributor

@christopherthielen What's our minimum version for 1.0 gonna be again?

@nateabele
Copy link
Contributor

@matsko Ping? (See #1900).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants