-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bower support #132
Comments
I'm intending to add the necessary bower meta-data so ui-router can be used with bower... just didn't get around to it yet ;-) |
For Bower, all it takes is a tag name of v0.0.1 and the "build" directory built and removed from the .gitignore... If you can create the Tag for v0.0.1 on the main repo, I have it ready in a pull request, but I haven't figure out how to submit my tag to the original repo... It'll be great to have it on Bower |
+1 |
1 similar comment
+1 |
There is a branch called ui-states (https://github.com/angular-ui/ui-router/tree/ui-states) which has the build folder. |
I saw talk that bower may begin to support specification of branches by name, or specification of specific commits. I couldn't figure which version might begin the support, or even if they had concluded to support it or not. It was a somewhat religious discussion on whether or not pointing to anything other than a tagged version was kosher. |
Release output should now be suitable for bower. Let me know if it's working for you. I also wasn't sure if it's more appropriate for the 'main' file to point to the .js or the .min.js (currently .min.js) |
So I need to add this to the Quick Start, is it just |
Yeah, that should do it... it seems to work as far as I can tell ;-) |
Thanks! Currently, in the bower.json it's 0.0.2 and in there is only a 0.0.1 git tag. I would add a PR but I can't create tags on the main repository |
The bower.json in the 0.0.1 tag is 0.0.1. I increment version numbers after
|
Cool... I was looking at the master, Thanks! |
This project is registered into Bower, but do not provide a build javascript file.
Why not?
The text was updated successfully, but these errors were encountered: