Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower support #132

Closed
murilobr opened this issue May 16, 2013 · 13 comments
Closed

Bower support #132

murilobr opened this issue May 16, 2013 · 13 comments

Comments

@murilobr
Copy link

This project is registered into Bower, but do not provide a build javascript file.
Why not?

@ksperling
Copy link
Contributor

I'm intending to add the necessary bower meta-data so ui-router can be used with bower... just didn't get around to it yet ;-)

@shairez
Copy link

shairez commented May 20, 2013

For Bower, all it takes is a tag name of v0.0.1 and the "build" directory built and removed from the .gitignore...

If you can create the Tag for v0.0.1 on the main repo, I have it ready in a pull request, but I haven't figure out how to submit my tag to the original repo...

It'll be great to have it on Bower

@hiromitz
Copy link

+1

1 similar comment
@t0mas
Copy link

t0mas commented May 21, 2013

+1

@murilobr
Copy link
Author

There is a branch called ui-states (https://github.com/angular-ui/ui-router/tree/ui-states) which has the build folder.
But Bower gets the master branch.

@laurelnaiad
Copy link

I saw talk that bower may begin to support specification of branches by name, or specification of specific commits. I couldn't figure which version might begin the support, or even if they had concluded to support it or not. It was a somewhat religious discussion on whether or not pointing to anything other than a tagged version was kosher.

@ksperling
Copy link
Contributor

Release output should now be suitable for bower. Let me know if it's working for you.

I also wasn't sure if it's more appropriate for the 'main' file to point to the .js or the .min.js (currently .min.js)

@timkindberg
Copy link
Contributor

So I need to add this to the Quick Start, is it just bower install angular-ui-router?

@ksperling
Copy link
Contributor

Yeah, that should do it... it seems to work as far as I can tell ;-)

@timkindberg
Copy link
Contributor

doesn't work on my windows machine, but pretty sure thats an npm bug.

clipboard image

@shairez
Copy link

shairez commented May 24, 2013

Thanks!
The tag number in the bower.json should be corresponding to the git tag

Currently, in the bower.json it's 0.0.2 and in there is only a 0.0.1 git tag.

I would add a PR but I can't create tags on the main repository

@ksperling
Copy link
Contributor

The bower.json in the 0.0.1 tag is 0.0.1. I increment version numbers after
a release because any new dev builds after 0.0.1 belong to the 0.0.2 series.
On May 25, 2013 11:45 AM, "Shai Reznik" [email protected] wrote:

Thanks!
The tag number in the bower.json should be corresponding to the git tag

Currently, in the bower.json it's 0.0.2 and in there is only a 0.0.1 git
tag.

I would add a PR but I can't create tags on the main repository


Reply to this email directly or view it on GitHubhttps://github.com//issues/132#issuecomment-18435795
.

@shairez
Copy link

shairez commented May 25, 2013

Cool... I was looking at the master, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants