Fix #630: Collapse crops content that would overflow. #828
Conversation
cambell-prince
commented
Aug 16, 2013
cambell-prince
commented
- Added overflow visible to the elements style when the expand transition is complete.
- overflow hidden is restored to the element before the collapse transition starts.
* Added overflow visible to the elements style when the expand transition is complete. * overflow hidden is restored to the element before the collapse transition starts.
|
@cambell-prince I'm not sure this is a correct fix as it would make all the overflowing elements within collapse / accordion visible. I don't think this is intention of those 2 mentioned directives. What I was suggesting in one of the other issues is that typeahead's popup element should be attached to |
|
It makes all overflowing elements visible only when the element is expanded, otherwise it has the original overflow hidden. When the element is expanded it seems unreasonable to impose an overflow on the containing element which crops the content. The fix works for me with containing either a typeahead (where the drop down shouldn't be cropped), and a popup menu (which I also don't want cropped). If there's an actual negative consequence do let me know the scenario and I'll have a look at it. |
|
What happens if an overflowing element is already overflowing when the transition starts? The main reason Bootstrap has the |
|
The overflow: visible is added after the expand animation completes. overflow:hidden is applied prior to the collapse starting. |
|
What is the status on this pull request? |
|
I wonder if we could stick to what the original Bootstrap code is doing, that is, adding the Doing so would fix #1192 @cambell-prince @caitp do you guys think it would work? |
|
That's what the existing patches are doing already, the main issue has been in updating the css model to match Bootstrap3 (and ensuring that transitions aren't broken, but I guess it's about time to switch those to using $animate now) |
|
@cambell-prince it was fixed in master, via 9eca35a, differently, by adding the |
|
@pkozlowski-opensource Thanks, that should work out fine. |
