This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(modal): add component support #6179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for `component` option
| @@ -35,15 +35,29 @@ The `$uibModal` service has only one method: `open(options)`. | |||
| _(Type: `boolean`, Default: `false`)_ - | |||
| When used with `controllerAs` & set to `true`, it will bind the $scope properties onto the controller. | |||
|
|
|||
| * `component` | |||
| _(Type: `string`, Example: `myComponent`)_ - | |||
| A string reference to the component to be rendered that is registered with Angular's compiler. If using a directive, the directive must have `restrict: 'E'` and a template or templateUrl set. | |||
There was a problem hiding this comment.
I think this implies that this is a BC, no?
There was a problem hiding this comment.
This is a completely new option - it isn't supported currently, so it isn't a BC at all.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
componentoptionThis should implement #5683.