Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(dropdown): align position with or without vertical scrollbar #5943

Closed
wants to merge 0 commits into from

Conversation

dolevd
Copy link
Contributor

@dolevd dolevd commented May 30, 2016

@icfantv
Copy link
Contributor

icfantv commented May 31, 2016

@dolevd your fix lacks tests and failed the eslinter which is why the build failed. you should try and do the build locally before actually committing so you can ensure your tests pass and the build succeeds. otherwise, you may just be wasting your time.

please correct the issues, squash your commits, and we will go from there.

@icfantv
Copy link
Contributor

icfantv commented Jun 13, 2016

@dolevd do you intend on fixing this or shall i close this? thanks.

@dolevd
Copy link
Contributor Author

dolevd commented Jun 14, 2016

Sorry for the radio silence, I'll fix this patch and resubmit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right alignment is off for dropdown-append-to-body .dropdown-menu-right when there's no vertical scrollbar
2 participants