fix(dropdown): Fix alignment for dropdown-append-to-body with .dropdown-menu-right when there's a vertical scrollbar

[dolevd]

Fixes #4317

This is going to be difficult to add tests for as the width of the scrollbar (that's used to calculate the alignment) is browser dependent.

Plunk with fix in place.

[wesleycho]

This LGTM - @RobJacobs is this the right fix?

[RobJacobs]

LGTM

[achenxp]

When there is no vertical scroll bar, the position of the dropdown is now incorrect.

[dolevd]

Can you please provide a plunkr that shows the problem?

[achenxp]

Here is the Plunkr.

[dolevd]

Thanks. My code is missing a check for overflow.
I'll send another pull request to fix this.

[achenxp]

Thanks for the quick action!

[dolevd]

I have a fix in my fork: dolevd@f838eb6

However, this might create a performance issue (since we need to calculate the styles of the append to element on every watch).
Any suggestions on how to proceed?

[dolevd]

I've opened another issue to handle this (#5942), since I don't think anyone is looking at the comments here anymore.