This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(tab): enable string as index #5827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need a unit tests before it can be considered for merging |
|
This is more involved and will need additional changes. See discussion in PR #5713, we should re-open that one. |
|
Waiting for this to be implemented. In the meantime, is there any workaround to add active class to the changed tab (ul li) on using string as index? |
|
@deeg @RobJacobs what is the status of #5713 you guys were working on? Is this something you guys can fix? People have been asking for this and we need to get it implemented. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable string index for tab.