feat(typeahead): Support for a typeahead-should-select function
#5794
Conversation
| } | ||
| }); | ||
| } | ||
| break; |
There was a problem hiding this comment.
True...what was there before had a break; at the end of each case, so I followed suit with the default case. I'll remove it.
|
Before this could get merged it would need docs added for the new attribute. |
|
Ah, good point. I'll look into adding that now. |
|
Any thoughts on the name of the option? Does it fit with the others? |
|
I think |
|
@wesleycho, that sounds good to me! @christor, let us know if you have any outstanding questions to get this finished. |
|
No, no more questions...just keep getting busy :-) |
|
@deeg, updated with suggestions and basic documentation |
|
@deeg, @wesleycho: please let me know if you would like any more changes to this. |
christor
changed the title
typeahead-is-select-trigger functiontypeahead-should-select function
|
@deeg , @wesleycho : Just following up to see if there's more work to be done here (don't mean to be a pest). Thanks. |
|
@christor, could you please squash this down to one commit? |
By default behaves as before. If specified, allows a custom function to be defined to determine whether the keydown event should trigger selection. Closes angular-ui#5671
|
@deeg All squashed up. Let me know if you need something more. Thanks. |
By default behaves as before. If specified, allows a custom function
to be defined to determine whether the keydown event should trigger
selection
Closes #5671