Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(modal): scroll padding only added once #5790

Closed
wants to merge 1 commit into from
Closed

fix(modal): scroll padding only added once #5790

wants to merge 1 commit into from

Conversation

RobJacobs
Copy link
Contributor

  • Ensure the scroll padding meant to offset the modal-open class only gets added once when mulitple modal windows are open.

Fixes #5789

This is going to be difficult to add tests for as the amount of (or if) scroll padding is browser dependent. Plunk with fix in place.

@RobJacobs
fix(modal): scroll padding only added once
c798767 
- Ensure the scroll padding meant to offset the modal-open class
only gets added once when mulitple modal windows are open.

Closes #5790
Fixes #5789
@RobJacobs RobJacobs self-assigned this Apr 12, 2016
@wesleycho wesleycho added this to the 1.3.2 milestone Apr 12, 2016
@wesleycho
Copy link
Contributor

LGTM, assuming tests pass

@deeg deeg closed this in aef08d5 Apr 12, 2016
@RobJacobs RobJacobs deleted the modal-scrollpadding branch April 21, 2016 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@RobJacobs RobJacobs

Labels
component: modal
Projects
None yet
Milestone
1.3.2
Development

Successfully merging this pull request may close these issues.

Body shifts to the right when opening a modal from within another modal
3 participants
@RobJacobs @wesleycho @deeg