This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(datepicker): dereference date initialization #5643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleycho
force-pushed
the
fix/datepicker-model-ref
branch
from
7446c2d to
b696389
Compare
|
LGTM if you don't want any tests |
|
I guess I can add a test for this - I'll do so sometime today or tomorrow. |
- Dereference the date set to active date to prevent model automatically updating from equal reference
wesleycho
force-pushed
the
fix/datepicker-model-ref
branch
from
b696389 to
4a001a0
Compare
|
Test added. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating from equal reference
Plunker with fix in action here.
This fixes #5441