Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(typeahead): apply angular watch to the typeahead-editable setting #4820

Closed
wants to merge 2 commits into from
+21 −0
Closed

feat(typeahead): apply angular watch to the typeahead-editable setting #4820

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1785de
feat(typeahead): apply angular watch to the typeahead-editable setting
Nov 5, 2015
2b6a463
feat(typeahead): added unit tests, removed call to setValidity
Nov 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/typeahead/typeahead.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ angular.module('ui.bootstrap.typeahead', ['ui.bootstrap.debounce', 'ui.bootstrap

//should it restrict model values to the ones selected from the popup only?
var isEditable = originalScope.$eval(attrs.typeaheadEditable) !== false;
originalScope.$watch(attrs.typeaheadEditable, function (newVal) {
isEditable = newVal !== false;
modelCtrl.$setValidity('editable', isEditable);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, and editable state should not be related to ngModel's validity. This is a bad change.

});

//binding to a variable that indicates if matches are being retrieved asynchronously
var isLoadingSetter = $parse(attrs.typeaheadLoading).assign || angular.noop;
Expand Down