Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(typeahead): clear typeahead input when value not from popup entered and editable is false #4752

Closed
wants to merge 1 commit into from

Conversation

chenyuzhcy
Copy link
Contributor

Closes #4265

@BobbieBarker
Copy link
Contributor

Lgtm thanks for the pr.

@wesleycho
Copy link
Contributor

My only question here is whether we should null the model as well in this situation. Otherwise, I'm fine with this PR.

@wesleycho wesleycho added this to the 1.0.0 milestone Oct 28, 2015
@chenyuzhcy
Copy link
Contributor Author

The model is already undefined in this situation

@wesleycho
Copy link
Contributor

LGTM - thanks for the high quality PR!

@wesleycho wesleycho closed this in 1d9294c Oct 28, 2015
@chenyuzhcy chenyuzhcy deleted the #4265 branch October 29, 2015 23:11
@kencaron
Copy link

kencaron commented Jan 5, 2016

This might not be the place for this -- found this PR when trying to debug an issue with typeahead-editable in the latest release (0.14.3).

Any ETA on the 14.4 release? Couldn't find anything specific in the roadmap wiki. I use typeahead-editable="false" heavily to prevent users from entering garbage in certain dropdowns.

@icfantv
Copy link
Contributor

icfantv commented Jan 5, 2016

@kencaron, there will not be a 0.14.4 release. we are trying to get 1.0 out the door and the release will be very soon. If you need this right away, please feel free to pull master and build a SNAPSHOT version.

@kirtikachouhan
Copy link

This will clear input with same match entered from popup also.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants