This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(carousel): re-enable deprecated directives #4527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect($log.warn.calls.count()).toBe(2); | ||
| expect($log.warn.calls.argsFor(0)).toEqual(['slide is now deprecated. Use uib-slide instead.']); | ||
| expect($log.warn.calls.count()).toBe(3); | ||
| expect($log.warn.calls.argsFor(1)).toEqual(['slide is now deprecated. Use uib-slide instead.']); |
wesleycho
force-pushed
the
fix/carousel-rename
branch
from
2fd509c to
86ed220
Compare
|
Added other checks as noted |
|
👍 |
|
Just wondering why this PR was created. Is it to resolve some issues? It should reference those issues, if that's the case, to track the reason for the change. |
|
@chrisirhc We are prefixing all the directives. There were a slip, and in the carousel, the deprecated directives were empty. They need to be fully functional. This PR puts back the functionality on those deprecated directives. This shouldn't be a |
| $log.warn('CarouselController is now deprecated. Use UibCarouselController instead.'); | ||
| } | ||
|
|
||
| angular.extend(this, $controller('UibCarouselController', { |
There was a problem hiding this comment.
Instead of extending this, you can probably return the $controller('Uib… directly.
There was a problem hiding this comment.
@Foxandxss mind if I just patch this in all of the components?
- Re-implement deprecated directives - Re-expose `CarouselController` with deprecation notice
wesleycho
force-pushed
the
fix/carousel-rename
branch
from
86ed220 to
3c8f22e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CarouselControllerwith deprecation notice