This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(rating): add uib prefix
#4502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When merging, please change the commit title to match the others. On the accordion, I decided to leave the local variable for the settings without prefix. Leads to a less verbose code and I think we should maintain one style. Which one? :) |
wesleycho
force-pushed
the
feat/rating-rename
branch
from
05ce9ed to
3de8794
Compare
wesleycho
force-pushed
the
feat/rating-rename
branch
from
3de8794 to
8b88703
Compare
|
👍 (it is use and not user :P) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uibprefix to all injectibles and directives