This repository has been archived by the owner on May 29, 2019. It is now read-only.
refactor(tooltip): rollup commit for several issues #4455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like this PR - it LGTM, but I have a question. Can the observers being bound and unbound be tested? |
|
This should also supercede #4431 |
|
@wesleycho I added tests for the observers as requested, PR #4431 is marked in the commit message. Let me know if you see anything else, thanks. |
|
LGTM |
This is a rollup commit intended to address several issues around the positioning and parsing of attributes. - Fixes issue introduced under PR #4311 where setting height and width in tooltip position function messed up arrow placement. - Fixes issue introduced under PR #4363 where setting visibility to hidden in tooltip position function caused elements in popover to lose focus. - Fixes issue #1780 where tooltip would render if content was just whitespace. - Fixes issue #3347 where tooltip isolate scope was being accessed after it was set to null. Observers will now be created/destroyed as tooltip opens/closes which will also offer a performance improvement. - Fixes issue #3557 by implementing evalAsync to set tooltip scope isOpen property. - Fixes issue #4335 where if model isOpen property is undefined, tooltip would call show/hide toggle function. - Closes PR #4429 where how the templated content was being evaluated could cause an infinite digest loop. Closes #4400 Closes #4418 Closes #4429 Closes #4431 Closes #4455 Fixes #1780 Fixes #3347 Fixes #3557 Fixes #4321 Fixes #4335
|
I'll let you do the honors of merging when you're ready @RobJacobs - got a lot of issues/PRs to trace down :) . |
This was referenced Oct 8, 2015
RobJacobs
added a commit
that referenced
this pull request
Oct 14, 2015
Under PR #4455 the timeout for the popup close delay was impacted by the evalAsync for setting the isOpen value. Moved the popup close delay timeout to the hideTooltipBind method so the hide method will now get called after the close popup delay. This will also ensure if the show method is called and the close timeout is cancelled, the isOpen property will not get toggled. Closes #4597 Fixes #4567
aroop
pushed a commit
to aroop/bootstrap
that referenced
this pull request
Oct 16, 2015
Under PR angular-ui#4455 the timeout for the popup close delay was impacted by the evalAsync for setting the isOpen value. Moved the popup close delay timeout to the hideTooltipBind method so the hide method will now get called after the close popup delay. This will also ensure if the show method is called and the close timeout is cancelled, the isOpen property will not get toggled. Closes angular-ui#4597 Fixes angular-ui#4567
jasonaden
pushed a commit
to deskfed/bootstrap
that referenced
this pull request
Jan 8, 2016
This is a rollup commit intended to address several issues around the positioning and parsing of attributes. - Fixes issue introduced under PR angular-ui#4311 where setting height and width in tooltip position function messed up arrow placement. - Fixes issue introduced under PR angular-ui#4363 where setting visibility to hidden in tooltip position function caused elements in popover to lose focus. - Fixes issue angular-ui#1780 where tooltip would render if content was just whitespace. - Fixes issue angular-ui#3347 where tooltip isolate scope was being accessed after it was set to null. Observers will now be created/destroyed as tooltip opens/closes which will also offer a performance improvement. - Fixes issue angular-ui#3557 by implementing evalAsync to set tooltip scope isOpen property. - Fixes issue angular-ui#4335 where if model isOpen property is undefined, tooltip would call show/hide toggle function. - Closes PR angular-ui#4429 where how the templated content was being evaluated could cause an infinite digest loop. Closes angular-ui#4400 Closes angular-ui#4418 Closes angular-ui#4429 Closes angular-ui#4431 Closes angular-ui#4455 Fixes angular-ui#1780 Fixes angular-ui#3347 Fixes angular-ui#3557 Fixes angular-ui#4321 Fixes angular-ui#4335
jasonaden
pushed a commit
to deskfed/bootstrap
that referenced
this pull request
Jan 8, 2016
This is a rollup commit intended to address several issues around the positioning and parsing of attributes. - Fixes issue introduced under PR angular-ui#4311 where setting height and width in tooltip position function messed up arrow placement. - Fixes issue introduced under PR angular-ui#4363 where setting visibility to hidden in tooltip position function caused elements in popover to lose focus. - Fixes issue angular-ui#1780 where tooltip would render if content was just whitespace. - Fixes issue angular-ui#3347 where tooltip isolate scope was being accessed after it was set to null. Observers will now be created/destroyed as tooltip opens/closes which will also offer a performance improvement. - Fixes issue angular-ui#3557 by implementing evalAsync to set tooltip scope isOpen property. - Fixes issue angular-ui#4335 where if model isOpen property is undefined, tooltip would call show/hide toggle function. - Closes PR angular-ui#4429 where how the templated content was being evaluated could cause an infinite digest loop. Closes angular-ui#4400 Closes angular-ui#4418 Closes angular-ui#4429 Closes angular-ui#4431 Closes angular-ui#4455 Fixes angular-ui#1780 Fixes angular-ui#3347 Fixes angular-ui#3557 Fixes angular-ui#4321 Fixes angular-ui#4335
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rollup commit intended to address several
issues around the positioning and parsing of
attributes.
height and width in tooltip position function
messed up arrow placement.
visibility to hidden in tooltip position function
caused elements in popover to lose focus.
content was just whitespace.
being accessed after it was set to null. Observers
will now be created/destroyed as tooltip opens/closes
which will also offer a performance improvement.
tooltip scope isOpen property.
undefined, tooltip would call show/hide toggle function.
was being evaluated could cause an infinite digest loop.
Closes #4400
Closes #4418
Closes #4429
Closes #4431
Fixes #1780
Fixes #3347
Fixes #3557
Fixes #4321
Fixes #4335