fix(popover): avoid flash of unstyled content #4428

bikegriffith · 2015-09-17T06:50:04Z

RobJacobs · 2015-09-17T12:38:09Z

This has been fixed under PR #4363 and PR #4379. This updated plunk shows the behavior with the latest code from master.

bikegriffith · 2015-09-17T12:38:22Z

src/tooltip/tooltip.js

@@ -149,8 +149,10 @@ angular.module('ui.bootstrap.tooltip', ['ui.bootstrap.position', 'ui.bootstrap.s
              if (!tooltip || !tooltip.html()) { return; }

              if (!positionTimeout) {
+                tooltip.hide(); // Hide to avoid FOUC until $timeout completes


positionTooltip is called frequently in some cases for an already open tooltip, so this could cause flickering.

bikegriffith · 2015-09-17T12:39:22Z

Thanks @RobJacobs. Just realizing this while auditing the code again and testing against a hacked version of 0.13.4 in my app. Will shut this down.

RobJacobs · 2015-09-17T13:23:44Z

@bikegriffith We're doing some more work to tighten up when the positioning method gets invoked and how often. Next significant change is PR #4418.

fix(popover): avoid flash of unstyled content

af9d18d

Fixes angular-ui#4427

bikegriffith reviewed Sep 17, 2015
View reviewed changes

bikegriffith closed this Sep 17, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(popover): avoid flash of unstyled content #4428

fix(popover): avoid flash of unstyled content #4428

bikegriffith commented Sep 17, 2015

RobJacobs commented Sep 17, 2015

bikegriffith Sep 17, 2015

bikegriffith commented Sep 17, 2015

RobJacobs commented Sep 17, 2015

fix(popover): avoid flash of unstyled content #4428

fix(popover): avoid flash of unstyled content #4428

Conversation

bikegriffith commented Sep 17, 2015

RobJacobs commented Sep 17, 2015

bikegriffith Sep 17, 2015

Choose a reason for hiding this comment

bikegriffith commented Sep 17, 2015

RobJacobs commented Sep 17, 2015