This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(dropdown): fix up arrow nav support #4330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add support for when user opens dropdown and then presses the up arrow key. Fixes angular-ui#4327
| expect(element.hasClass(dropdownConfig.openClass)).toBe(true); | ||
|
|
||
| triggerKeyDown($document, 38); | ||
| var elems = element.find('ul').eq(0).find('a'); |
There was a problem hiding this comment.
This should be var elems = element.find('ul li').eq(0).find('a');
There was a problem hiding this comment.
the selector isn't the problem, rather the up trigger is not causing the anchor tag to become the document.activeElement. so the focus check will fail. why this is the case, i don't know. but essentially, the up arrow key is doing nothing here.
* add support for when user opens dropdown and then presses the up arrow key. Fixes angular-ui#4327
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4327