This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(datepicker): allow custom templates #4157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wesleycho
commented
Aug 8, 2015
wesleycho
commented
- Allow custom templates for datepicker and popup
- Expose controller to template
- Allow custom templates for datepicker and popup - Expose controller to template
|
Good for me, but when we allow custom templates to be used on directives, we need to double check that pulling custom templates from remote (a different file in a plunker would work) doesn't break it. Angular won't wait for a directive (and its children) to be fully there in the DOM so animations (if any) could break. |
| scope: { | ||
| datepickerMode: '=?', | ||
| dateDisabled: '&', | ||
| customClass: '&', | ||
| shortcutPropagation: '&?' | ||
| }, | ||
| require: ['datepicker', '?^ngModel'], | ||
| require: ['datepicker', '^ngModel'], |
There was a problem hiding this comment.
Should note, this change would cause #1913 to be resolved.
|
I think that is fine - they should be bundling it in $templateCache. |
wesleycho
force-pushed
the
feat/datepicker-custom-templates
branch
from
48e8839 to
bf83761
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.