-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(datepicker): add suppression of validation for #3836 #4115
feat(datepicker): add suppression of validation for #3836 #4115
Conversation
@@ -1,5 +1,9 @@ | |||
angular.module('ui.bootstrap.datepicker', ['ui.bootstrap.dateparser', 'ui.bootstrap.position']) | |||
|
|||
.value('$datepickerSuppressError', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make it a boolean - no need for an object here.
Just make all changes related to my comment and this PR should be good to get in. |
The only reason I made it an object is because when it's a literal, changes you make upon injection don't take effect (setting |
I think that is fine - there really isn't a great use case for toggling suppression on or off once the app is running. |
Okay I'll go ahead and make the change then |
So in order to test properly I had to wrap the other tests in their own describe block so that I could override the |
That's perfectly fine |
Can you squash your commits into one? |
Squash complete |
LGTM - merging shortly. Thanks for the work! |
No problem! Thanks for this entire library, it's great! |
This adds the
$datepickerSuppressError
value provider which has anisSuppressed
property to allow the option to suppress the$log
error inDatepickerController
. This was made to address #3836