Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

datepicker dynamic min-mode and max-mode #3843

Closed
wants to merge 14 commits into from

Conversation

Slimmmo
Copy link
Contributor

@Slimmmo Slimmmo commented Jun 22, 2015

Simply enabling the ability to change modes dynamically without having to use two different datepickers and hiding one based on the current mode.

Also fixes min-mode for popups. #2618

@Slimmmo Slimmmo closed this Jun 22, 2015
@Slimmmo Slimmmo reopened this Jun 22, 2015
@wesleycho
Copy link
Contributor

Can you add a test for this? I will merge this afterwards - otherwise this looks good.

@wesleycho wesleycho added this to the Backlog milestone Jul 19, 2015
@Slimmmo
Copy link
Contributor Author

Slimmmo commented Jul 20, 2015

Hi Wesley,

I made a little change since you posted to make it slightly more fool-proof. If you update min-mode to something larger than datepicker-mode, it will now automatically update datepicker-mode to match min-mode. Likewise for max-mode but for smaller values.

Please let me know if those tests aren't adequate. There isn't really that much to test though.

Thanks.

@wesleycho
Copy link
Contributor

I need to review this deeper - the split off of the minMode and maxMode from the original iterator into a custom one has me wary.

@wesleycho
Copy link
Contributor

Thanks for this work - in the future though, please squash the commits. It ended up being quite a pain resolving the conflict multiple times because the commits were never squashed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants