-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(datepicker): add optional force-position attr #3782
Conversation
@rvanbaalen could you look at the PR in free-time? That is the next time when I need this feature, so I've decided to implement. Let me know if you've got some suggestions. |
@@ -471,7 +471,8 @@ function ($compile, $parse, $document, $position, dateFilter, dateParser, datepi | |||
clearText: '@', | |||
closeText: '@', | |||
dateDisabled: '&', | |||
customClass: '&' | |||
customClass: '&', | |||
forcePosition: '@' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just calling it position
would be fine.
History needs to be fixed, there is pollution from what appears to be other repositories. The base branch should branch directly from |
b6245a0
to
d140395
Compare
d140395
to
ad667c9
Compare
-history fixed @wesleycho could you take a look? |
I'll take a harder look later today - my only main point of concern here is multiple PRs dealing with positioning but not implementing the feature in |
Thinking about this, I believe that the API should be tweaked to support single directions as well, i.e.
|
Doing a little more investigation, I should have a PR ready by tomorrow with that modification. |
Looking forward to $position changes. I agree that the feature should be on the $position service itself. Thanks @wesleycho . |
Closing in favor of #4762. |
Specify where the datepicker element should be displayed